-
Notifications
You must be signed in to change notification settings - Fork 734
handled case of assets union #3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
|
||
/** | ||
* Adds dot at end of string. | ||
*/ | ||
type DotExtendedString<T extends string> = `${T}.`; | ||
|
||
|
||
/** | ||
* Converts path string to a an array of the path. Acts like split('.') | ||
* | ||
* Example: PathArray<'path1.path2.path3'> --> ['path1', 'path2', 'path3'] | ||
*/ | ||
type PathArray<S extends string> = | ||
DotExtendedString<S> extends `${infer A}.${infer B}` ? (A extends '' ? [] : [A, ...PathArray<B>]) : []; | ||
|
||
/** | ||
* Creates a nested record with the nesting of path of the strings in the array that ends with object K. | ||
* | ||
* Example: NestedRecord<'path1.path2', {last: number}> --> {path1: { path2: {last: number}}} | ||
*/ | ||
type NestedRecord<Path extends string[], K extends object = {}> = Path extends [infer Next, ...infer Rest] | ||
? {[P in Next]: NestedRecord<Rest, K>} | ||
: K; | ||
|
||
/** | ||
* Gets type of K at Path. | ||
*/ | ||
type DeepGet<K extends object, Path extends string> = _DeepGet<K, PathArray<Path>>; | ||
|
||
type _DeepGet<K extends object, T extends Array<string>> = T extends [infer First, ...infer Rest] | ||
? First extends keyof K | ||
? _DeepGet<K[First], Rest> | ||
: never | ||
: K; | ||
|
||
/** | ||
* Create nested object from a PathString. | ||
* | ||
* Example: PathRecord<'path1.path2', {last: number}> --> {path1: { path2: {last: number}}} | ||
*/ | ||
type PathRecord<T extends string, K = {}> = NestedRecord<PathArray<T>, K>; | ||
|
||
|
||
/** | ||
* Combines a record at Path with existing record of an object or creates it if it doesn't exist. | ||
* | ||
* Example: AssertRecord<{path1: {path2: {last: number}}}, 'path1.path2', {reallyLast: string}> --> {path1: {path2: {last: number; reallyLast: string}}} | ||
*/ | ||
export type AssetRecord<This extends object, Path extends string, Asset extends object = {}> = PathRecord< | ||
Path, | ||
DeepGet<This, Path> extends never ? Asset : (DeepGet<This, Path> & Asset) | ||
>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I reviewed this again, this time more thoroughly..
Since the TS utils are pretty complicated to understand at first glance I'd suggest to make them more readable.
T
andK
to something with more meaning..for example, maybe change this
AssetRecord<T extends string, K extends object = {}, This extends object>
toAssetRecord<PATH extends string, ASSETS extends object = {}, ASSETS_CLASS extends object>