Infra/picker testing coverage #3107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
previously approved these changes
Jun 2, 2024
M-i-k-e-l
reviewed
Jun 2, 2024
M-i-k-e-l
reviewed
Jun 17, 2024
| expect(onDismiss).toHaveBeenCalledTimes(2); // TODO: this should be 1 | ||
| }); | ||
|
|
||
| // TODO: this test is not passing yet |
There was a problem hiding this comment.
When should this start working?
There was a problem hiding this comment.
The issue here is that the onShow function is triggered only when the modal is fully open.
Iv'e tried to use act and waitFor didn't help.
I'll change the TODO comment to fix this test in the future, WDYT ?
| // describe.skip('WheelPicker', () => { | ||
| // }); | ||
|
|
||
| //TODO: add more tests for different props | ||
| describe('Picker field types', () => { |
There was a problem hiding this comment.
fixed, bad merging from master after merging the new useFieldType hook.
Comment on lines
83
to
85
| const getStyle = () => { | ||
| return StyleSheet.flatten(driver.getElement().props.style) as TextStyle; | ||
| }; |
There was a problem hiding this comment.
I don't think you're using this anymore, do we want to keep this change?
M-i-k-e-l
reviewed
Jun 27, 2024
| expect(onDismiss).toHaveBeenCalledTimes(2); // TODO: this should be 1 | ||
| }); | ||
|
|
||
| // TODO: this test is not passing yet |
M-i-k-e-l
reviewed
Jun 27, 2024
Comment on lines
+285
to
+290
| const label = screen.getByTestId(`${testID}.settings.type.label`); | ||
| const placeholder = screen.getByTestId(`${testID}.settings.type.placeholder`); | ||
| expect(label).toBeTruthy(); | ||
| expect(placeholder).toBeTruthy(); | ||
| expect(label.props.children).toEqual(undefined); | ||
| expect(placeholder.props.children).toEqual(placeholderText); |
There was a problem hiding this comment.
Ideally the driver will return the label text and the placeholder text, please fix or add a ticket
M-i-k-e-l
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker testing coverage.
Testing picker modes (modal and dialog) - currently there is an issue with WheelPicker testing.
Testing picker field types by style.
Search functionality testing have the same issue as the WheelPicker.
Changelog
Picker testing coverage
Additional info
MADS-4181