Infra/picker types arrangement #3149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
src/components/picker/types.tsx
Outdated
| /** | ||
| * Pass for different field type UI (form, filter or settings) | ||
| */ | ||
| fieldType?: PickerFieldTypes | `${PickerFieldTypes}`; |
There was a problem hiding this comment.
Please move before 'renderInput'
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Co-authored-by: Inbal Tish <[email protected]>
Co-authored-by: Inbal Tish <[email protected]>
Co-authored-by: Inbal Tish <[email protected]>
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
reviewed
Jun 27, 2024
Inbal-Tish
approved these changes
Jun 27, 2024
|
@adids1221 Approved. Let's run the tests here and then merge if we didn't break anything |
|
depends on testing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker types arrangement, new
useNewPickerPropsto convert old props into new props.Picker types divide into type of the component that uses these props.
Also some props are renamed according to the component that uses them.
Changelog
Picker types arrangement - new props, props deprecation.
Additional info
None