Slider - Increased hit target #3531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanyiz
changed the title
adids1221
reviewed
Mar 3, 2025
| @@ -28,14 +28,21 @@ interface ThumbProps extends ViewProps { | |||
|
|
|||
| const SHADOW_RADIUS = 4; | |||
| const THUMB_SIZE = 24; | |||
| const THUMB_ACCESSIBLE_HITSLOP = Math.max(0, 48 - THUMB_SIZE) / 2; | |||
There was a problem hiding this comment.
As we discussed before, hitSlop can be Rect or number.
Since all the values are the same let's pass the THUMB_ACCESSIBLE_HITSLOP number as default.
Please check it and confirm.
There was a problem hiding this comment.
The thumb is view and not a pressable. For some reason view's hit slop doesn't receive number :/
https://reactnative.dev/docs/0.73/view#hitslop
adids1221
approved these changes
Mar 11, 2025
|
@nitzanyiz Approved as we discussed about it. |
Inbal-Tish
reviewed
Mar 12, 2025
| @@ -28,14 +28,21 @@ interface ThumbProps extends ViewProps { | |||
|
|
|||
| const SHADOW_RADIUS = 4; | |||
| const THUMB_SIZE = 24; | |||
| const THUMB_ACCESSIBLE_HITSLOP = Math.max(0, 48 - THUMB_SIZE) / 2; | |||
| const DEFAULT_THUMB_HIT_SLOP = { | |||
There was a problem hiding this comment.
You don't need the DEFAULT_THUMB_HIT_SLOP. If all sides are equal you can pass one value - THUMB_ACCESSIBLE_HITSLOP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added accessible hitSlop to the slider thumb.
Changelog
Incubator.Slider - Increased thumb hitSlop.
Additional info
MADS-4591