Skip to content

Slider - Increased hit target #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 16, 2025
Merged

Slider - Increased hit target #3531

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c1db67d
Increased default thumb hit slop
nitzanyiz Feb 25, 2025
f0ec8a9
Added hitslop to Incubator.Slider thumb
nitzanyiz Feb 26, 2025
fc97c2b
Added hitslop to all thumbs
nitzanyiz Feb 26, 2025
d9d9213
Removed extra const
nitzanyiz Feb 26, 2025
9240279
Removed extra line
nitzanyiz Feb 26, 2025
345b3fe
Revert old slider index changes
nitzanyiz Feb 26, 2025
b2a6e43
Revert old slider index changes
nitzanyiz Feb 26, 2025
2fee35c
Merge branch 'master' into fix/slider-accessibilityHitTarget
nitzanyiz Feb 27, 2025
ca654db
Merge remote-tracking branch 'origin' into fix/slider-accessibilityHi…
nitzanyiz Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/incubator/slider/Thumb.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,21 @@ interface ThumbProps extends ViewProps {

const SHADOW_RADIUS = 4;
const THUMB_SIZE = 24;
const THUMB_ACCESSIBLE_HITSLOP = Math.max(0, 48 - THUMB_SIZE) / 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed before, hitSlop can be Rect or number.
Since all the values are the same let's pass the THUMB_ACCESSIBLE_HITSLOP number as default.
Please check it and confirm.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thumb is view and not a pressable. For some reason view's hit slop doesn't receive number :/
https://reactnative.dev/docs/0.73/view#hitslop

const DEFAULT_THUMB_HIT_SLOP = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the DEFAULT_THUMB_HIT_SLOP. If all sides are equal you can pass one value - THUMB_ACCESSIBLE_HITSLOP

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3531 (comment)

top: THUMB_ACCESSIBLE_HITSLOP,
bottom: THUMB_ACCESSIBLE_HITSLOP,
left: THUMB_ACCESSIBLE_HITSLOP,
right: THUMB_ACCESSIBLE_HITSLOP
} as const;

const Thumb = (props: ThumbProps) => {
const {
disabled,
disableActiveStyling,
activeStyle,
defaultStyle,
hitSlop,
hitSlop = DEFAULT_THUMB_HIT_SLOP,
onSeekStart,
onSeekEnd,
start,
Expand Down