Feat/new dialog #505
Merged
Feat/new dialog #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Key in non template dialogs
ethanshar
reviewed
Aug 14, 2019
ethanshar
reviewed
Aug 26, 2019
| this.animatedValue = new Animated.Value(0); | ||
| this.state = { | ||
| visible: props.visible, | ||
| isAnimating: false, |
There was a problem hiding this comment.
I don't think it's the isAnimating that make things work, but the fact you run a setState (line 134) before you start the animation, not sure what's causing it to work properly.
even if you'll do
this.setState({bla: true}, () => animation.start(animationEndCallback)); it will work fine.
check why the setState is matter here.
ethanshar
reviewed
Aug 29, 2019
src/components/dialog/index.js
Outdated
| initPositions() { | ||
| this.setState({ | ||
| deltaY: new Animated.Value(this.initialPosition) | ||
| createStyles(props) { |
There was a problem hiding this comment.
Why did u move this function into the class, not sure I follow what's going on here with all the styles.
There was a problem hiding this comment.
I thought it's more organized this way. Is there a drawback?
There was a problem hiding this comment.
Reverted (added a key in the screen as discussed)
ethanshar
reviewed
Sep 1, 2019
src/components/dialog/index.js
Outdated
| renderDialogView = () => { | ||
| const {children, renderPannableHeader, style, bottom, top} = this.props; | ||
| const {dialogVisibility} = this.state; | ||
| const Container = !_.isUndefined(renderPannableHeader) ? View : PanListenerView; |
# Conflicts: # src/components/panningViews/panDismissibleView.js
ethanshar
approved these changes
Sep 2, 2019
ethanshar
added a commit
that referenced
this pull request
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.