Skip to content

Feat/new dialog #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Sep 2, 2019
Merged

Feat/new dialog #505

Show file tree
Hide file tree
Changes from 57 commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
2cef012
New Dialog - it's a start
M-i-k-e-l Aug 14, 2019
75cb56b
Remove useSafeArea usage
M-i-k-e-l Aug 14, 2019
c726a54
Rename private methods + expose public static methods + change di…
M-i-k-e-l Aug 14, 2019
a56130b
Remove redundant example
M-i-k-e-l Aug 14, 2019
166c79a
Merge branch 'master' into feat/new-dialog
M-i-k-e-l Aug 14, 2019
1255bb3
Send props to Dialog's onDismiss + remove arrow functions
M-i-k-e-l Aug 14, 2019
142b5dd
Mostly prettify
M-i-k-e-l Aug 14, 2019
5a4e140
Rename
M-i-k-e-l Aug 14, 2019
1a57234
supportedOrientations
M-i-k-e-l Aug 14, 2019
9fd3d23
Remove old deprecation warnings
M-i-k-e-l Aug 14, 2019
a1eb7cf
Change SafeAreaView to useSafeArea
M-i-k-e-l Aug 14, 2019
d182b22
renderHeader --> renderPannableHeader
M-i-k-e-l Aug 14, 2019
52f1d18
renderHeader --> renderPannableHeader (2)
M-i-k-e-l Aug 14, 2019
a62837d
Copy props instead of spreading them
M-i-k-e-l Aug 14, 2019
5cc9a54
Rename style
M-i-k-e-l Aug 14, 2019
2147d83
Create PanResponderView and PanAnimatableView
M-i-k-e-l Aug 18, 2019
2ce17eb
Remove unused prop
M-i-k-e-l Aug 18, 2019
1012a27
Fix PanResponderView and PanAnimatableView
M-i-k-e-l Aug 18, 2019
30aec97
Dialog - continued
M-i-k-e-l Aug 20, 2019
9592b83
Working (mostly)
M-i-k-e-l Aug 22, 2019
2c7dccb
Merge branch 'master' into feat/new-dialog
M-i-k-e-l Aug 22, 2019
c712a40
Remove PanDismissibleView
M-i-k-e-l Aug 22, 2019
029c552
Prettify
M-i-k-e-l Aug 22, 2019
87d7272
Refactor
M-i-k-e-l Aug 22, 2019
7ad332e
Small refactor
M-i-k-e-l Aug 22, 2019
eb27a85
Add TODOs
M-i-k-e-l Aug 22, 2019
fbadf1b
Rename example ID to reactNativeOverlay
M-i-k-e-l Aug 22, 2019
1520133
Fix header examples
M-i-k-e-l Aug 22, 2019
b2f2ab0
Reduce complexity of initial location
M-i-k-e-l Aug 25, 2019
80e8c26
dialogKey --> orientationKey + renderVisibleContainer --> renderDia…
M-i-k-e-l Aug 25, 2019
e8d0b37
Add visible props to DialogDismissibleView (remove the need to refere…
M-i-k-e-l Aug 25, 2019
de48bd7
dynamicStyles --> styles + default height from 70% to undefined
M-i-k-e-l Aug 25, 2019
e54eec2
Add default left\top so there's less code
M-i-k-e-l Aug 25, 2019
80f0762
Move style creation to getter (getAnimationStyle)
M-i-k-e-l Aug 25, 2019
0ebdb0d
Move to styles + rename some methods
M-i-k-e-l Aug 25, 2019
369f4fc
Remove TODOs
M-i-k-e-l Aug 25, 2019
42ed821
Merge branch 'master' into feat/new-dialog
M-i-k-e-l Aug 25, 2019
e80752d
Change animation value 0 <--> 1
M-i-k-e-l Aug 25, 2019
6290a93
Prettify
M-i-k-e-l Aug 25, 2019
737e10f
hideDialog --> hideDialogView
M-i-k-e-l Aug 25, 2019
55b1ea6
Send props in the deprecated dialog's onDismiss
M-i-k-e-l Aug 25, 2019
9df77bb
Remove unused import
M-i-k-e-l Aug 25, 2019
28ac260
Refactor
M-i-k-e-l Aug 26, 2019
d85f768
Fix counter not initialized.
M-i-k-e-l Aug 26, 2019
d9634fa
Remove unused code
M-i-k-e-l Aug 26, 2019
d930955
Remove unnecessary code
M-i-k-e-l Aug 26, 2019
4df7b6e
Remove unused prop
M-i-k-e-l Aug 27, 2019
44aef47
Make dialog centered horizontally no matter what the alignment is
M-i-k-e-l Aug 27, 2019
35d04b8
Fix alignment & height not changing after constructor has been called
M-i-k-e-l Aug 28, 2019
b02ee0f
Merge branch 'master' into feat/new-dialog
M-i-k-e-l Aug 28, 2019
f26e28d
Remove disablePan (if panDirection is undefined there will be no pan)
M-i-k-e-l Aug 28, 2019
6ff2508
Add warnings for unrecommended usage
M-i-k-e-l Aug 28, 2019
ddeaa86
Refactor - add isSwiping
M-i-k-e-l Aug 28, 2019
069d36f
Rename size --> dialogViewSize
M-i-k-e-l Aug 29, 2019
c1e4fa2
Revert style location change + change key in dialog screen instead …
M-i-k-e-l Aug 29, 2019
32b70fa
Change default configuration of the dialog screen
M-i-k-e-l Aug 29, 2019
6ef5ba5
Add TODO
M-i-k-e-l Aug 29, 2019
d2c1bf8
Remove unused code
M-i-k-e-l Sep 1, 2019
ea0f09e
Merge branch 'master' into feat/new-dialog
M-i-k-e-l Sep 1, 2019
3bdd0d2
Remove isUndefined
M-i-k-e-l Sep 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demo/src/screens/MenuStructure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export const navigationData = {
{title: 'Overlays', tags: 'overlay image', screen: 'unicorn.components.OverlaysScreen'},
{title: 'Page Control', tags: 'page', screen: 'unicorn.components.PageControlScreen'},
{title: 'Pan Listener', tags: 'pan swipe drag listener', screen: 'unicorn.components.PanListenerScreen'},
{title: 'Pan Responder', tags: 'pan swipe drag responder', screen: 'unicorn.components.PanResponderScreen'},
{title: 'Shared Transition', tags: 'shared transition element', screen: 'unicorn.components.SharedTransitionScreen'},
{title: 'TabBar', tags: 'tab bar', screen: 'unicorn.components.TabBarScreen'},
{title: 'Toast', tags: 'toast top bottom snackbar', screen: 'unicorn.components.ToastsScreen'},
Expand Down
Loading