ui: Slightly adjust app bar and scaffold-background, to align with web #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These colors are known in the web app as (in order of appearance): --color-background-navbar --color-navbar-bottom-border --color-background (The nav-bar border color is unchanged, or changed within a rounding error.) The colors we had before this were reasonable, since they were taken from the Figma. But the Figma is now over a year old, and it seems at least as reasonable to follow the web app, especially since they're only slightly different. Moreover, we want to implement dark theme soon (zulip#95), and it'll be best to take the light and dark styles from the same source. That currently has to be the web app, since the Figma doesn't have a dark theme.
chrisbobbe
added
a-design
|
|
Closing as superseded by #687; see discussion linked from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These colors are known in the web app as (in order of appearance):
--color-background-navbar
--color-navbar-bottom-border
--color-background
(The nav-bar border color is unchanged, or changed within a rounding error.)
The colors we had before this were reasonable, since they were taken from the Figma. But the Figma is now over a year old, and it seems at least as reasonable to follow the web app, especially since they're only slightly different. Moreover, we want to implement dark theme soon (#95), and it'll be best to take the light and dark styles from the same source. That currently has to be the web app, since the Figma doesn't have a dark theme.
Screenshots coming soon.