Skip to content

ui: Slightly adjust app bar and scaffold-background, to align with web #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ui: Slightly adjust app bar and scaffold-background, to align with web #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/widgets/theme.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,17 @@ import 'text.dart';
ThemeData zulipThemeData(BuildContext context) {
return ThemeData(
typography: zulipTypography(context),
appBarTheme: const AppBarTheme(
appBarTheme: AppBarTheme(
// Set these two fields to prevent a color change in [AppBar]s when
// there is something scrolled under it. If an app bar hasn't been
// given a backgroundColor directly or by theme, it uses
// ColorScheme.surfaceContainer for the scrolled-under state and
// ColorScheme.surface otherwise, and those are different colors.
scrolledUnderElevation: 0,
backgroundColor: Color(0xfff5f5f5),
backgroundColor: const HSLColor.fromAHSL(1, 0, 0, 0.97).toColor(),

shape: Border(bottom: BorderSide(color: Color(0xffcccccc))),
shape: Border(
bottom: BorderSide(color: const HSLColor.fromAHSL(1, 0, 0, 0.8).toColor())),
),
// This applies Material 3's color system to produce a palette of
// appropriately matching and contrasting colors for use in a UI.
Expand All @@ -27,7 +28,7 @@ ThemeData zulipThemeData(BuildContext context) {
colorScheme: ColorScheme.fromSeed(
seedColor: kZulipBrandColor,
),
scaffoldBackgroundColor: const Color(0xfff6f6f6),
scaffoldBackgroundColor: const HSLColor.fromAHSL(1, 0, 0, 0.94).toColor(),
tooltipTheme: const TooltipThemeData(preferBelow: false),
);
}
Expand Down
Loading