Skip to content

Update the linker script to support RW/ZI/Heap span across RAM banks #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update the linker script to support RW/ZI/Heap span across RAM banks #10003

wants to merge 2 commits into from

Conversation

deepikabhavnani
Copy link

Description

As per EWARM Development guide

A region consists of one or several memory ranges, where each memory range
consists of a continuous sequence of bytes in a specific memory. Several ranges
can be combined by using region expressions. Note that those ranges do
not need to be consecutive or even in the same memory.

RAM region here is made as combination of 2-RAM banks
define region RAM_region = mem:[from SRAM2_start to SRAM2_end]
| mem:[from SRAM1_start to SRAM1_end];

block can be placed in specific region which can have several ranges.
place in RAM_region { block RW };
place in RAM_region { block ZI };
place in RAM_region { block HEAP };

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@deepikabhavnani deepikabhavnani mentioned this pull request Mar 7, 2019
Closed
@ciarmcom ciarmcom requested review from screamerbg and a team March 8, 2019 00:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 8, 2019

@deepikabhavnani, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

@cmonr cmonr requested review from a team March 27, 2019 21:41
@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

Closing for now since @deepikabhavnani is out until 2nd week of April.

@cmonr cmonr closed this Mar 27, 2019
@deepikabhavnani
Copy link
Author

@ARMmbed/mbed-os-maintainers - Can we please reopen this?

@cmonr cmonr reopened this Apr 9, 2019
@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2019

@deepikabhavnani Done!

@deepikabhavnani
Copy link
Author

Rebased to re-trigger CI, and pick up latest fixes.

@sg- sg- removed the needs: review label Apr 9, 2019
@deepikabhavnani
Copy link
Author

@ARMmbed/team-st-mcd - Please review

jeromecoutant
jeromecoutant reviewed Apr 10, 2019
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could approve, but who takes the action to align all icf files for all targets ?

@jeromecoutant
Copy link
Collaborator

I could approve

In fact not... tests with DISCO_L475 are all failing with that current patch :-(

@deepikabhavnani
Copy link
Author

In fact not... tests with DISCO_L475 are all failing with that current patch

Will try to grab the device and test. Thanks

@deepikabhavnani deepikabhavnani mentioned this pull request Apr 10, 2019
Closed
Update the linker script to support RW/ZI/Heap span across RAM banks
95dcd75 
As per EWARM Development guide
A region consists of one or several memory ranges, where each memory range
consists of a continuous sequence of bytes in a specific memory. Several ranges
can be combined by using region expressions. Note that those ranges do
not need to be consecutive or even in the same memory.

RAM region here is made as combination of 2-RAM banks
define region RAM_region = mem:[from __SRAM2_start__ to __SRAM2_end__]
                          | mem:[from __SRAM1_start__ to __SRAM1_end__];

block can be placed in specific region which can have several ranges.
place in RAM_region                    {  block RW };
place in RAM_region                    {  block ZI };
place in RAM_region                    {  block HEAP };
@deepikabhavnani
Copy link
Author

tests with DISCO_L475 are all failing with that current patch

@jeromecoutant - I have fixed the issue, verified with few test cases. Please review

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 12, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2019

Looks like these changes result in build failure for tls test. Please review

@0xc0170 0xc0170 removed the request for review from screamerbg April 12, 2019 11:48
@deepikabhavnani
Copy link
Author

Looks like these changes result in build failure for tls test. Please review

Fixed by 59e78a6

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 15, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2019

Needs fixes for IAR build

@deepikabhavnani
Copy link
Author

Closing this. Linker files in this PR will be updated as part of #10303. Thanks @juhoeskeli

@sg- sg- removed the needs: work label Apr 16, 2019
@jeromecoutant
Copy link
Collaborator

Linker files in this PR will be updated as part of #10303

Note that this PR is updating STM32L443 and STM32L475 linker scripts,
whereas #10303 updates STM32L486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deepikabhavnani @ciarmcom @cmonr @jeromecoutant @0xc0170 @mbed-ci @sg-