Skip to content

add platform MOTE_L152RC #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

add platform MOTE_L152RC #1023

wants to merge 17 commits into from

Conversation

dudmuck
Copy link
Contributor

@dudmuck dudmuck commented Apr 8, 2015

This is platform https://developer.mbed.org/platforms/namote-72/
It is nearly identical to NUCLEO_L152RE.
Files in targets/hal/TARGET_STM/TARGET_STM32L1/ moved to subdirectory where the file needed to be modified for the platform.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2015

Hello, can you sign cla please: http://developer.mbed.org/contributor_agreement/

Another thing, the half of commits here are synch with upstream, you either squash these or I'll run manually merge squash.

@ohagendorf
Copy link
Contributor

This target development started before the reorganization of mbed\targets\hal\TARGET_STM folders. Perhaps it would be a good idea to adapt it to the current structure.

@dudmuck
Copy link
Contributor Author

dudmuck commented Apr 9, 2015

The hal reorg for this platform is mbed/targets/hal/TARGET_STM/TARGET_STM32L1.
The following files were moved from TARGET_STM32L1 to TARGET_NUCLEO_L152RE:
gpio_object.h
rtc_api.c
serial_api.c
sleep.c
This is to accommodate changes needed specific to L152RC device, so these for files are in the target subdirectory under TARGET_STM32L1. All files in TARGET_STM32L1 are those which work for all STM32L1 targets.

@ohagendorf
Copy link
Contributor

It is not necessary to double files with minor differences, e.g. the serial_api.c. Please have a look into another hal folder, e.g. for the STM32F4. You can use defines to handle different number of uarts etc.

@dudmuck
Copy link
Contributor Author

dudmuck commented Apr 9, 2015

ok, duplicate files eliminated and replaced with #if defined()

@ohagendorf
Copy link
Contributor

Yes, that is what I meant.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 21, 2015

I'll merge this manually, will squash those commits and let you know once done (will close this).

0xc0170 added a commit that referenced this pull request Apr 23, 2015
commit 5390a0eb7fc28dda30993602652350fd0ad87df0
Merge: 7c4831f 3998966
Author: 0xc0170 <[email protected]>
Date:   Thu Apr 23 08:48:31 2015 +0100

    Merge branch 'master' of https://github.com/dudmuck/mbed into dudmuck-master

    Conflicts:
    	workspace_tools/export/uvision4.py

commit 3998966
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Thu Apr 9 13:45:09 2015 -0700

    using defines for platform specific requirement

commit 755c5d9
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Wed Apr 8 14:59:47 2015 -0700

    added device ID for MOTE_L152RC

commit d812fb0
Merge: 6ad66e8 158cbeb
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Wed Apr 8 07:25:23 2015 -0700

    Merge remote-tracking branch 'upstream/master'

commit 6ad66e8
Merge: 14a1807 cfb9dd1
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Fri Mar 27 15:54:03 2015 -0700

    merged upstream

commit 14a1807
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Mar 24 10:01:02 2015 -0700

    RTC subSeconds at 16384Hz

commit 32d75d0
Merge: bc84c03 ea01d61
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Mar 24 09:59:43 2015 -0700

    Merge remote-tracking branch 'upstream/master'

commit bc84c03
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Mon Mar 16 16:26:18 2015 -0700

    handle HSE-PLL enabled upone deepsleep wakeup

commit 11bfe69
Merge: b7cec55 fdc75bf
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Mon Mar 16 14:37:11 2015 -0700

    Merge remote-tracking branch 'upstream/master'

commit b7cec55
Merge: c5b61f5 4b74c54
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Mon Mar 9 13:15:56 2015 -0700

    syncd with upstream

commit c5b61f5
Merge: c16a115 9d2fd3e
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Mar 3 14:05:54 2015 -0800

    syncd with upstream

commit c16a115
Merge: 51efd61 1b2a621
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Feb 24 09:48:55 2015 -0800

    Merge remote-tracking branch 'upstream/master'

commit 51efd61
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Feb 24 09:48:22 2015 -0800

    MOTE_L152RC

commit a122226
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Feb 24 09:46:08 2015 -0800

    renamed SEMTECH_LORA915 to MOTE_L152RC

commit 88fcf53
Merge: 3e291c1 8648ff5
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Mon Feb 23 08:11:48 2015 -0800

    Merge remote-tracking branch 'upstream/master'

commit 3e291c1
Merge: a59aefc c9e93d2
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Feb 17 19:04:04 2015 -0800

    Merge remote-tracking branch 'upstream/master'

    syncing my fork with master

commit a59aefc
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Feb 17 18:46:27 2015 -0800

    added SEMTECH_LORA915 to python scripts

commit 15b1989
Author: U-owner-PC\owner <Wayne Roberts>
Date:   Tue Feb 17 18:42:13 2015 -0800

    added platform SEMTECH_LORA915
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 23, 2015

Squashed Merged manually, via 809d8aa

Please retest, there was one merge conflict I had to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants