Update CMSIS to 5.5.1 #10366
Merged
Update CMSIS to 5.5.1 #10366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having them in cmsis causes grief when attempting to update CMSIS with the importer script.
(cherry picked from commit b882548)
(cherry picked from commit 1752803)
(cherry picked from commit 6a6e3ac)
- TF-M v8m secure-side implements their own TZ context APIs so need to avoid building the Mbed implementation. (cherry picked from commit d3f7abd)
In case of ARM compiler, idle and timer thread stack though assigned to `.bss.os` section since not zero initialized are part of `data` section. In this commit, we are moving stacks of idle and timer thread to bss section and thereby saving ROM space. (cherry picked from commit ba92372)
CMSIS repo does not support pre-processor defines, hence multiple assembly files are added for secure/non-secure and floating point tools. Mbed OS tools support assembly file pre-processing, but the build system does not support multiple assembly files for each target, hence updating the assembly files. 1. Patch RTX so irq_cm4f.S files work with no FPU targets 2. Patch RTX so irq_armv8mml.S files to work with and without FPU 2. Patch RTX so irq_armv8mml.S and irq_armv8mbl.S files to work with secure and non-secure builds (cherry picked from commit 0946627)
ciarmcom
requested review from
bulislaw,
c1728p9,
deepikabhavnani,
SenRamakri and
a team
|
@kjbracey-arm, thank you for your changes. |
0xc0170
approved these changes
Apr 10, 2019
deepikabhavnani
approved these changes
Apr 10, 2019
|
while we wait for some additional reviews, CI scheduled |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Restarting test, both show success in logs |
bridadan
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Import CMSIS 5.5.1.
Replaces #10148, which was cherry-picking just one RTX update.
Slight changes made to the importer JSON, and fault handler/exception code moved from
cmsistoplatform, as its presence incmsiscomplicates the import process. (Was moved fromrtostoplatformearly in first version of #8332, then was moved tocmsison the grounds that "core specific code is in CMSIS", but it doesn't make sense to mix our own code with the CMSIS code for maintenance purposes).Pull request type
Reviewers
@deepikabhavnani, @SenRamakri, @bulislaw, @c1728p9
Release Notes