Skip to content

mbed-coap buffer overflow fix #12146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2020
Merged

mbed-coap buffer overflow fix #12146

merged 2 commits into from
Jan 2, 2020

Conversation

ristohuhtala
Copy link
Contributor

@ristohuhtala ristohuhtala commented Dec 20, 2019

Summary of changes

Fixed mbed-coap buffer overflow when paring CoAP message. Changed buffer handling when CoAP message is parsed. Buffer size is checked to avoid overflow.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@anttiylitokola @yogpan01


@ciarmcom ciarmcom requested review from anttiylitokola, yogpan01 and a team December 20, 2019 10:00
@ciarmcom
Copy link
Member

@ristohuhtala, thank you for your changes.
@anttiylitokola @yogpan01 @ARMmbed/mbed-os-maintainers please review.

@ristohuhtala
Copy link
Contributor Author

Added CHANGELOG.md changes to this PR like @yogpan01 suggested.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2020

As #12147 contains as well the changelog, please remove it from this one. This will be merged first, and 12147 right after containing the changelog.

@ristohuhtala
Copy link
Contributor Author

As #12147 contains as well the changelog, please remove it from this one. This will be merged first, and 12147 right after containing the changelog.

I will remove it

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2020

mbed-os-ci_cloud-client-pytest restarted

@0xc0170 0xc0170 merged commit b79da0c into ARMmbed:master Jan 2, 2020
@bulislaw
Copy link
Member

bulislaw commented Jan 7, 2020

I'm assuming @JanneKiiskila will want it in next patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants