Skip to content

mbed-coap changelog.md update #12148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

mbed-coap changelog.md update #12148

wants to merge 1 commit into from

Conversation

ristohuhtala
Copy link
Contributor

@ristohuhtala ristohuhtala commented Dec 20, 2019

Summary of changes

Update mbed-coap CHANGELOG.md with v5.1.3 information.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@teetak01 @yogpan01


@ristohuhtala
Copy link
Contributor Author

Changes listed on CHANGELOG.md are in following PRs:
#12147
#12146

@ristohuhtala ristohuhtala changed the title mbed-coap changelog-md update mbed-coap changelog.md update Dec 20, 2019
@ciarmcom ciarmcom requested review from teetak01, yogpan01 and a team December 20, 2019 12:00
@ciarmcom
Copy link
Member

@ristohuhtala, thank you for your changes.
@yogpan01 @teetak01 @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 23, 2019

We usually get an update with fixes, was there a reason for splitting into 3? It's easier to review, just as it is split, might not be easier to follow in the log (this is an update from an upstream repository).

@kjbracey
Copy link
Contributor

We usually get an update with fixes, was there a reason for splitting into 3? It's easier to review, just as it is split, might not be easier to follow in the log (this is an update from an upstream repository).

Anna asked for it to be split - I would have gone with the single upstream update myself.

Original was #12124

@adbridge
Copy link
Contributor

adbridge commented Dec 23, 2019

We usually get an update with fixes, was there a reason for splitting into 3? It's easier to review, just as it is split, might not be easier to follow in the log (this is an update from an upstream repository).

Anna asked for it to be split - I would have gone with the single upstream update myself.

Original was #12124

My bad. I think I didn't pay close enough attention to the fact this was an actual coap lib update! Although all the changes were in one commit hence my request to split it. Perhaps for these in the future, one PR but with individual commits for each unique change would have been better! This is an area where our documentation is a little vague and something perhaps we should look at in the new year.

@adbridge
Copy link
Contributor

@yogpan01 @teetak01 do either of you also wish to review ?

@yogpan01
Copy link
Contributor

@ristohuhtala I think you misunderstood about PR split. You need to keep the bug fixes into own PRs but then those have to be accompanied with their own CHANGELOG update. It doesn't make any sense to create a PR with just CHANGELOG when the actual fixes are in some other PRs.
I suggest to include the CHANGELOG in #12146 and #12147

@ristohuhtala
Copy link
Contributor Author

@ristohuhtala I think you misunderstood about PR split. You need to keep the bug fixes into own PRs but then those have to be accompanied with their own CHANGELOG update. It doesn't make any sense to create a PR with just CHANGELOG when the actual fixes are in some other PRs.
I suggest to include the CHANGELOG in #12146 and #12147

I could add change logs to those two PR. This were misunderstanding for me.

@ristohuhtala
Copy link
Contributor Author

Commit change log file changes to those two PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants