-
Notifications
You must be signed in to change notification settings - Fork 3k
mbed-coap changelog.md update #12148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbed-coap changelog.md update #12148
Conversation
@ristohuhtala, thank you for your changes. |
We usually get an update with fixes, was there a reason for splitting into 3? It's easier to review, just as it is split, might not be easier to follow in the log (this is an update from an upstream repository). |
Anna asked for it to be split - I would have gone with the single upstream update myself. Original was #12124 |
My bad. I think I didn't pay close enough attention to the fact this was an actual coap lib update! Although all the changes were in one commit hence my request to split it. Perhaps for these in the future, one PR but with individual commits for each unique change would have been better! This is an area where our documentation is a little vague and something perhaps we should look at in the new year. |
@ristohuhtala I think you misunderstood about PR split. You need to keep the bug fixes into own PRs but then those have to be accompanied with their own CHANGELOG update. It doesn't make any sense to create a PR with just CHANGELOG when the actual fixes are in some other PRs. |
I could add change logs to those two PR. This were misunderstanding for me. |
Commit change log file changes to those two PRs. |
Summary of changes
Update mbed-coap CHANGELOG.md with v5.1.3 information.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@teetak01 @yogpan01