Skip to content

mbed-coap uint16 overflow fix #12147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2020
Merged

mbed-coap uint16 overflow fix #12147

merged 2 commits into from
Jan 2, 2020

Conversation

ristohuhtala
Copy link
Contributor

Summary of changes

Fixed mbed-coap uint16 overflow when calculating packet data size. Now before packet size is returned overflow is checked.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@anttiylitokola @kjbracey-arm

@ciarmcom ciarmcom requested review from anttiylitokola, kjbracey and a team December 20, 2019 10:00
@ciarmcom
Copy link
Member

@ristohuhtala, thank you for your changes.
@anttiylitokola @kjbracey-arm @ARMmbed/mbed-os-maintainers please review.

@ristohuhtala ristohuhtala mentioned this pull request Dec 20, 2019
Closed
@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor

@anttiylitokola @kjbracey-arm would you like to review ?

@ristohuhtala
Copy link
Contributor Author

Added CHANGELOG.md changes to this PR like @yogpan01 suggested.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2020

Ci started

@0xc0170 0xc0170 mentioned this pull request Jan 2, 2020
Merged
@mbed-ci
Copy link

mbed-ci commented Jan 2, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit de798c4 into ARMmbed:master Jan 2, 2020
@0xc0170 0xc0170 removed the needs: CI label Jan 2, 2020
@bulislaw
Copy link
Member

bulislaw commented Jan 7, 2020

I'm assuming @JanneKiiskila will want it in the next patch?

@JanneKiiskila
Copy link
Contributor

Yep!

@teetak01 teetak01 mentioned this pull request Apr 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@anttiylitokola anttiylitokola anttiylitokola approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

@adbridge adbridge Awaiting requested review from adbridge

Assignees
No one assigned
Labels
release-version: 5.15.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ristohuhtala @ciarmcom @adbridge @mbed-ci @0xc0170 @bulislaw @JanneKiiskila @anttiylitokola