BLE: Gap platform abstraction layer #5295

pan- · 2017-10-11T10:59:53Z

Description

Add an interface exposing the primitives needed to realize operations defined in
the GAP layer. Data types, event and function definitions follow closely HCI
commands and events defined in the Bluetooth specification.

This adapter shall be implemented by porters if they want to use the generic
implementation of the Gap implementation.

Status

READY

Migrations

NO

pan- · 2017-10-11T11:02:03Z

@marcbonnici @nvlsianpu @apalmieriGH May you review this PR ?

Other will follows containing the implementation of the GenericGAP, an abstraction managing the GAP server and the pal::Gap implementation for the Cordio stack.

mbed-ci · 2017-10-11T13:17:51Z

Build : SUCCESS

Build number : 114
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5295/

Triggering tests

/test mbed-os

mbed-ci · 2017-10-11T21:18:59Z

Test : SUCCESS

Build number : 40
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5295/40

0xc0170 · 2017-10-12T08:09:14Z

@tommikas Can you restart jenkins CI please here?

marcbonnici · 2017-10-11T12:12:57Z

features/FEATURE_BLE/ble/pal/GapEvents.h

+     * Construct a new GapConnectionCompleteEvent.
+     *
+     * @param status Status of the operation: 0x00 in case of success otherwise
+     * the error code associated with the faillure.


'faillure' is misspelt

marcbonnici · 2017-10-11T12:22:03Z

features/FEATURE_BLE/ble/pal/GapEvents.h

+
+
+/**
+ * Report advertising from on or more LE device.


marcbonnici · 2017-10-11T13:14:02Z

features/FEATURE_BLE/ble/pal/GapTypes.h

+    /**
+     * Construct advertising data from an array.
+     *
+     * @param input_value Reference to the array containing the advertising dat


marcbonnici · 2017-10-11T13:25:24Z

features/FEATURE_BLE/ble/pal/PalGap.h

+     * or RESOLVABLE_PRIVATE_ADDRESS_RANDOM_FALLBACK then the peer address
+     * parameters (type and address) will be used to find the local IRK.
+     *
+     * @param peer_address_type Address type of the peer.sw


Additional sw

marcbonnici · 2017-10-11T13:52:56Z

features/FEATURE_BLE/ble/pal/PalGap.h

+     *     - A connection is created.
+     *     - Time out in case of high duty cycle directed advertising.
+     *
+     * If the random address as not been set and the advertising parameter


*has not been

marcbonnici · 2017-10-11T13:53:11Z

features/FEATURE_BLE/ble/pal/PalGap.h

+     * If the random address as not been set and the advertising parameter
+     * own_address_type is set to 0x01 then the procedure shall fail.
+     *
+     * If the random address as not been set and the advertising parameter


This still needs correcting.

marcbonnici · 2017-10-11T13:58:03Z

features/FEATURE_BLE/ble/pal/PalGap.h

+     * if initiator_policy use the whitelist.
+     *
+     * @param Address used by the advertiser in its advertising packets. Not
+     * usedif initiator_policy use the whitelist.


marcbonnici · 2017-10-11T13:59:45Z

features/FEATURE_BLE/ble/pal/PalGap.h

+     * @note The value returned can change over time.
+     *
+     * @return The number of entries that can be stored in the LE subsystem. It
+     * range from 0x01 tp 0xFF.


mbed-ci · 2017-10-12T09:58:58Z

Build : SUCCESS

Build number : 141
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5295/

Triggering tests

/test mbed-os

adbridge · 2017-10-16T15:13:37Z

"@marcbonnici @nvlsianpu @apalmieriGH May you review this PR ?"
Any further update on this ? Looks like it needs re-review?

pan- · 2017-10-16T15:15:48Z

I updated the PR according to @marcbonnici comments.

0xc0170 · 2017-10-19T10:44:18Z

@marcbonnici - approved?

marcbonnici · 2017-10-19T10:46:26Z

features/FEATURE_BLE/ble/pal/PalGap.h

+     * If the random address has not been set and the advertising parameter
+     * own_address_type is set to 0x01 then the procedure shall fail.
+     *
+     * If the random address as not been set and the advertising parameter


This still needs correcting.
"as" -> "has"

0xc0170 · 2017-10-19T15:29:28Z

Anyone else for review?

theotherjimmy · 2017-10-23T15:26:03Z

@pan- Could you correct the typo? then we can get this show on the road.

adbridge · 2017-10-31T15:40:44Z

@pan- Could you please address the comments

This interface expose the primitives needed to realize operations defined in the GAP layer. Data types, event and function definitions follow closely HCI commands and events defined in the Bluetooth specification.

pan- · 2017-10-31T17:44:09Z

@adbridge I've addressed the comments.

theotherjimmy · 2017-11-02T15:29:39Z

@studavekar did these build and test triggers get dropped?

studavekar · 2017-11-02T16:52:33Z

@theotherjimmy i don't see a morph command for 744abca.

0xc0170 · 2017-11-03T15:30:19Z

/morph build

mbed-ci · 2017-11-04T05:13:32Z

Build : SUCCESS

Build number : 434
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5295/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-11-04T08:15:45Z

Test : FAILURE

Build number : 227
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5295/227

studavekar · 2017-11-06T20:13:48Z

/morph test

mbed-ci · 2017-11-08T05:48:14Z

Test : SUCCESS

Build number : 271
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5295/271

0xc0170 added the needs: review label Oct 11, 2017

pan- changed the title ~~Gap platform abstraction layer~~ BLE: Gap platform abstraction layer Oct 11, 2017

pan- mentioned this pull request Oct 11, 2017

BLE: Generic access service abstraction layer #5296

Merged

pan- added the component: ble label Oct 11, 2017

marcbonnici reviewed Oct 12, 2017

View reviewed changes

pan- force-pushed the GAP-platform-abstraction-layer branch from c7ceb0b to 11c0f93 Compare October 12, 2017 09:40

BLE: Add safe Enum abstraction.

a917b90

pan- force-pushed the GAP-platform-abstraction-layer branch from 11c0f93 to 2b80876 Compare October 15, 2017 15:44

marcbonnici reviewed Oct 19, 2017

View reviewed changes

BLE: Adaptation interface of the GAP layer.

744abca

This interface expose the primitives needed to realize operations defined in the GAP layer. Data types, event and function definitions follow closely HCI commands and events defined in the Bluetooth specification.

pan- force-pushed the GAP-platform-abstraction-layer branch from 2b80876 to 744abca Compare October 31, 2017 17:42

marcbonnici approved these changes Nov 1, 2017

View reviewed changes

theotherjimmy added needs: CI and removed needs: review labels Nov 2, 2017

apalmieriGH approved these changes Nov 2, 2017

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Nov 8, 2017

pan- mentioned this pull request Nov 8, 2017

Cordio: Pal Gap implementation #5313

Merged

0xc0170 added the release-version: 5.7.0-rc1 label Nov 9, 2017

0xc0170 merged commit 82f5b58 into ARMmbed:master Nov 9, 2017

0xc0170 removed the ready for merge label Nov 9, 2017

pan- deleted the GAP-platform-abstraction-layer branch July 3, 2018 11:04

BLE: Gap platform abstraction layer #5295

BLE: Gap platform abstraction layer #5295

Uh oh!

Conversation

pan- commented Oct 11, 2017

Description

Status

Migrations

Uh oh!

pan- commented Oct 11, 2017

Uh oh!

mbed-ci commented Oct 11, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 11, 2017

Uh oh!

0xc0170 commented Oct 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Oct 12, 2017

Triggering tests

Uh oh!

adbridge commented Oct 16, 2017

Uh oh!

pan- commented Oct 16, 2017

Uh oh!

0xc0170 commented Oct 19, 2017

Uh oh!

marcbonnici Oct 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 19, 2017

Uh oh!

theotherjimmy commented Oct 23, 2017

Uh oh!

adbridge commented Oct 31, 2017

Uh oh!

pan- commented Oct 31, 2017

Uh oh!

theotherjimmy commented Nov 2, 2017

Uh oh!

studavekar commented Nov 2, 2017

Uh oh!

0xc0170 commented Nov 3, 2017

Uh oh!

mbed-ci commented Nov 4, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 4, 2017

Uh oh!

studavekar commented Nov 6, 2017

Uh oh!

mbed-ci commented Nov 8, 2017

Uh oh!

Uh oh!

marcbonnici Oct 19, 2017 •

edited

Loading