Cordio: Pal Gap implementation #5313

pan- · 2017-10-12T20:00:17Z

Description

This PR replace the existing specific Gap implementation by the generic Gap implementation. The following pal implementations has been added for pal::Gap and pal::GenericAccessService.

The Gatt server function write and areUpdateEnabled has also been fixed, they where relying on the default gatt connection handle which is plainly incorrect in a multiple client context.

Status

READY

Migrations

NO

Related PRs

#5311

Note

Diff can be found here: https://github.com/pan-/mbed/compare/ble-generic-gap..pan-:ble-cordio-pal-gap

pan- · 2017-10-12T20:04:02Z

@marcbonnici @0xc0170 @scartmell-arm Could you review this PR ?

theotherjimmy · 2017-10-13T15:20:29Z

@AnotherButler FYI huge bit of new docs in this PR.

ghost · 2017-10-13T15:26:26Z

features/FEATURE_BLE/ble/SafeEnum.h

+     * @return true if the inner value of lhs and rhs are not equal and false 
+     * otherwise.
+     */
+	friend bool operator!=(SafeEnum lhs, SafeEnum rhs) {


The comparison operators could be implemented in terms of each other so only == and < need to be maintained if anything changes.

friend bool operator!=(SafeEnum lhs, SafeEnum rhs) { return !(operator==(lhs, rhs)); }

Agreed however it is not necessary to use the prefix notation to invoke the equal operator, the infix notation is fine (lhs == rhs).

pan- · 2017-10-16T08:17:09Z

@AnotherButler APIs in this PR are no meant to be publicly used. They are supposed to be used by partners which implement mbed BLE.

It would be a good thing to have the documentation of these APIs in a porting guide of the BLE platform abstraction layer however it would be terrible and counter productive to have references to these APIs in the documentation of the public API.

This interface expose the primitives needed to realize operations defined in the GAP layer. Data types, event and function definitions follow closely HCI commands and events defined in the Bluetooth specification.

Add an abstraction which manage the state of the GAP service exposed by the GATT server.

This filter prevent events to be signaled multiple times to the upper layer. It also signal events to a newly set event processor hook.

To help generic code, an interface of an event queue at the PAL level has been added. Implementation can either rely on the event mechanism internal to the stack or use the SimpleEventQueue implementation provided by this patch.

Generic implementation of the GAP class. It allows porters to have a working Gap implementation by implementing the following abstraction layer primitives: - pal::Gap: Adaptation for GAP related primitives. - pal::EventQueue: simple interface to the inner event queue of the stack. pal::SimpleEventQueue can also be used as an implementation. - pal::GenericAccessService: Accessors to the Generic Access Service present in the GATT server.

…eUpdatesEnabled

0xc0170 · 2017-11-02T08:30:11Z

/morph build

0xc0170 · 2017-11-02T08:35:41Z

@pan- This depend on #5311 as it states, is that correct? what order they should be integrated (it is a chain of patches).

mbed-ci · 2017-11-02T08:54:26Z

Build : SUCCESS

Build number : 410
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5313/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-11-02T10:22:36Z

Test : SUCCESS

Build number : 201
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5313/201

pan- · 2017-11-08T16:06:18Z

@0xc0170 Order: #5295 => #5296 => #5299 => #5300 => #5311 => #5313 . It is indicated in the Related PR section.

mbed-ci · 2017-11-08T17:12:49Z

Build : SUCCESS

Build number : 471
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5313/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-11-09T03:53:10Z

Test : SUCCESS

Build number : 290
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5313/290

0xc0170 · 2017-11-09T11:04:47Z

@0xc0170 Order: #5295 => #5296 => #5299 => #5300 => #5311 => #5313 . It is indicated in the Related PR section.

Thanks, will follow the order. The first should get in today, then the second one and so on.

pan- · 2018-01-08T11:22:01Z

@0xc0170 Any update on this ?

0xc0170 · 2018-01-08T11:29:05Z

/morph build

mbed-ci · 2018-01-08T12:27:22Z

Build : SUCCESS

Build number : 818
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5313/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-08T15:19:03Z

Exporter Build : SUCCESS

Build number : 469
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5313/

mbed-ci · 2018-01-08T18:37:34Z

Test : SUCCESS

Build number : 658
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5313/658

pan- added component: ble needs: preceding PR labels Oct 12, 2017

ghost reviewed Oct 13, 2017

View reviewed changes

ghost approved these changes Oct 13, 2017

View reviewed changes

BLE: Add safe Enum abstraction.

a917b90

pan- force-pushed the ble-cordio-pal-gap branch 2 times, most recently from 788c67f to e8e23e8 Compare October 15, 2017 16:34

adbridge added the needs: work label Oct 16, 2017

marcbonnici approved these changes Oct 16, 2017

View reviewed changes

adbridge added needs: CI and removed needs: work labels Oct 24, 2017

pan- added 9 commits October 31, 2017 17:32

BLE: Adaptation interface of the GAP layer.

744abca

This interface expose the primitives needed to realize operations defined in the GAP layer. Data types, event and function definitions follow closely HCI commands and events defined in the Bluetooth specification.

BLE: Generic Access Service Adaptation layer

0025b68

Add an abstraction which manage the state of the GAP service exposed by the GATT server.

BLE: Add generic event filter.

63668cb

This filter prevent events to be signaled multiple times to the upper layer. It also signal events to a newly set event processor hook.

BLE: Event Queue interface at the pal level.

953739c

To help generic code, an interface of an event queue at the PAL level has been added. Implementation can either rely on the event mechanism internal to the stack or use the SimpleEventQueue implementation provided by this patch.

BLE: Cordio implementation of pal::GenericAccessService.

0d0cdb6

BLE: Cordio implementation of ble::pal::Gap.

c30eee0

BLE: Cordio fix default connection handle for GattServer write and ar…

e9170e6

…eUpdatesEnabled

Cordio: Use GenericGap instead of CordioGap.

c8747aa

pan- force-pushed the ble-cordio-pal-gap branch from e8e23e8 to c8747aa Compare October 31, 2017 17:43

0xc0170 removed the needs: CI label Nov 9, 2017

BLE: Generic Gap - fix address management.

70e5a14

theotherjimmy added needs: review needs: preceding PR and removed needs: preceding PR labels Jan 4, 2018

0xc0170 added release-version: 5.8.0-rc1 and removed needs: preceding PR needs: review labels Jan 8, 2018

theotherjimmy added the needs: CI label Jan 8, 2018

0xc0170 added ready for merge and removed needs: CI labels Jan 9, 2018

cmonr merged commit dc87f0b into ARMmbed:master Jan 11, 2018

cmonr removed the ready for merge label Jan 11, 2018

pan- deleted the ble-cordio-pal-gap branch July 3, 2018 11:04

Cordio: Pal Gap implementation #5313

Cordio: Pal Gap implementation #5313

Uh oh!

Conversation

pan- commented Oct 12, 2017

Description

Status

Migrations

Related PRs

Note

Uh oh!

pan- commented Oct 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Oct 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pan- Oct 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pan- commented Oct 16, 2017

Uh oh!

0xc0170 commented Nov 2, 2017

Uh oh!

0xc0170 commented Nov 2, 2017

Uh oh!

mbed-ci commented Nov 2, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 2, 2017

Uh oh!

pan- commented Nov 8, 2017

Uh oh!

mbed-ci commented Nov 8, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 9, 2017

Uh oh!

0xc0170 commented Nov 9, 2017

Uh oh!

pan- commented Jan 8, 2018

Uh oh!

0xc0170 commented Jan 8, 2018

Uh oh!

mbed-ci commented Jan 8, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 8, 2018

Uh oh!

mbed-ci commented Jan 8, 2018

Uh oh!

Uh oh!

pan- commented Oct 12, 2017 •

edited

Loading

pan- Oct 15, 2017 •

edited

Loading