BLE: Generic access service abstraction layer #5296
Conversation
|
@marcbonnici @nvlsianpu @apalmieriGH Could you review this PR ? |
Build : SUCCESSBuild number : 115 Triggering tests/test mbed-os |
Test : SUCCESSBuild number : 39 |
|
@tommikas jenkins CI restart (no url here) pls |
pan-
force-pushed
the
generic-access-service-abstraction-layer
branch
from
c5a5b2e to
fa61c01
Compare
|
@0xc0170 It's being built now. (As are the other 3 jobs Jenkins hadn't noticed.) The url still hasn't updated here though so I'll keep an eye on it. |
Build : SUCCESSBuild number : 142 Triggering tests/test mbed-os |
pan-
force-pushed
the
generic-access-service-abstraction-layer
branch
from
fa61c01 to
43f8af6
Compare
This interface expose the primitives needed to realize operations defined in the GAP layer. Data types, event and function definitions follow closely HCI commands and events defined in the Bluetooth specification.
Add an abstraction which manage the state of the GAP service exposed by the GATT server.
pan-
force-pushed
the
generic-access-service-abstraction-layer
branch
from
43f8af6 to
0025b68
Compare
|
@0xc0170 Any update ? |
|
/morph build |
Build : FAILUREBuild number : 500 |
Build : SUCCESSBuild number : 509 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 124 |
Test : SUCCESSBuild number : 319 |
| * Public identity address. | ||
| * @note remove once privacy mode is supported. | ||
| */ | ||
| PUBLIC_IDENTITY_ADDRESS = 0x02, |
There was a problem hiding this comment.
I'm not sure what this mean - how this is related to addressed defined by BLE standard (this, and next item)?
There was a problem hiding this comment.
The note should not be here.
| GapDisconnectionCompleteEvent( | ||
| uint8_t status, | ||
| connection_handle_t connection_handle, | ||
| uint8_t reason |
There was a problem hiding this comment.
why not type of disconnection_reason_t?
There was a problem hiding this comment.
Because the reasons of the disconnection can be most of hci_error_code_t; it is not necessarily initiated by the user. disconnection_reason_t list the reasons that can be used by the user code to ends the connection.
| * - Time out in case of high duty cycle directed advertising. | ||
| * | ||
| * If the random address has not been set and the advertising parameter | ||
| * own_address_type is set to 0x01 then the procedure shall fail. |
Description
The top level API, GAP, mixed up different concepts, the GAP layer and the exposition of GAP parameters through the Generic Access Service at the GATT layer.
At the pal level, those concepts are separated, therefore this PR add an abstraction which manage the state of the GAP service exposed by the GATT server.
Status
READY
Migrations
NO
Related PRs
#5295
Note
Diff can be found here: pan-/mbed@GAP-platform-abstraction-layer...pan-:generic-access-service-abstraction-layer