Skip to content

rtl8195am: fix ARM section error #6226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2018
Merged

rtl8195am: fix ARM section error #6226

merged 1 commit into from
Mar 8, 2018

Conversation

M-ichae-l
Copy link
Contributor

@M-ichae-l M-ichae-l commented Feb 27, 2018 •
edited
Loading

Description

fix section error, ARM compiler uses IRAM1.bss to calculate the heap size

fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler

rebase update for #6061

Pull request type

  • Fix

@M-ichae-l
mbed-os_ci-test-fixed_rtl8195am
9d30469 
fix section error, ARM compiler uses IRAM1.bss to calculate the heap size

fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler
@M-ichae-l M-ichae-l mentioned this pull request Feb 27, 2018
Closed
cmonr
cmonr reviewed Feb 27, 2018
View reviewed changes
targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/TOOLCHAIN_ARM_STD/rtl8195a.sct
@@ -29,9 +29,6 @@ LR_IRAM 0x10007000 (0x70000 - 0x7000) {
*libc.a (+RW)
*(.sdram.data*)
*lib_peripheral_mbed_arm.ar (+RW)
}

RW_IRAM2 +0 UNINIT FIXED {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the main thing that this PR is doing is replacing RAM2 block usage with the RAM1 block?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some part of the memory at the end of RAM2 which contains data that we donot want to touch throughout the lifecycle of the program. RAM2 block usage might create a scenario where the memory might reach the addresses that we donot wish to touch, hence we have replaced RAM2 block usage with RAM1.

targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/trng_api.c
@@ -17,6 +17,10 @@
#include "analogin_api.h"
#include "analogin_ext.h"

#ifdef CONFIG_MBED_ENABLED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these new #ifdefs enabling that wasn't enabled before?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our platform has its own std libraries that are defined under platform_stdlib.h, some of these define are modified to support our specific realtek platform and are different from the original stdlib.h hence we have this define enabled here.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1275
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6226/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Test : SUCCESS

Build number : 1069
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6226/1069

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Exporter Build : FAILURE

Build number : 942
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6226/

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

/morph export-build

2 similar comments
@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

@0xc0170 You might need to re-kick these builds.

@studavekar Morph restart appears to not have work this time.

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

/morph export-build

2 similar comments
@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

/morph export-build

@studavekar
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 7, 2018

Exporter Build : SUCCESS

Build number : 1024
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6226/

@cmonr
Copy link
Contributor

cmonr commented Mar 7, 2018

/morph mbed2-build

@M-ichae-l M-ichae-l mentioned this pull request Mar 7, 2018
Closed
5 tasks
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2018

/morph mbed2-build

@0xc0170 0xc0170 changed the title mbed-os_ci-test-fixed_rtl8195am rtl8195am: fix ARM section error Mar 7, 2018
@0xc0170 0xc0170 merged commit 4e7ad0d into ARMmbed:master Mar 8, 2018
@M-ichae-l M-ichae-l deleted the mbed-os_ci-test-fixed_rtl8195am branch March 12, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantrar prashantrar prashantrar left review comments

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@theotherjimmy theotherjimmy Awaiting requested review from theotherjimmy

Assignees
No one assigned
Labels
release-version: 5.7.7 release-version: 5.8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@M-ichae-l @0xc0170 @mbed-ci @cmonr @studavekar @prashantrar