Skip to content

rtl8195am - fix ci-test issues with ARM compiler #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

M-ichae-l
Copy link
Contributor

Description

  • fix section error, ARM compiler uses IRAM1.bss to calculate the heap size

  • fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler

Status

READY

Migrations

NONE

Related PRs

NONE

Todos

NONE

Deploy notes

NONE

Steps to test or reproduce

NONE

pi-anl and others added 2 commits February 6, 2018 12:51
Fix ci-test issues with ARM compiler
- fix section error, ARM compiler uses IRAM1.bss to calculate the heap size
- fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler
@mbed-ci
Copy link

mbed-ci commented Feb 12, 2018

--none--

0xc0170
0xc0170 previously approved these changes Feb 12, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2018

Build : SUCCESS

Build number : 1109
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6061/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2018

/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2018

fix ci-test issues

@M-ichae-l Might be worth sharing what ci-test issues is this fixing

Are these :

fix section error, ARM compiler uses IRAM1.bss to calculate the heap size

fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler

what ci-tests?

@M-ichae-l
Copy link
Contributor Author

@0xc0170
Hi,
The "concurrent gpio" and "pwm" tests request to initialize the analogin (A2) and pwm (pwm0 and pwm3). However, "_memset()" conflict will cause the initialization fails to set memory to be "0". Standard "memset()" will make the initialization successful.

@M-ichae-l
Copy link
Contributor Author

I have ran a simple "_memset()" test under the ci-test environment. The "_memset()" is not able to reset memory. The "_memset()" is defined from "c_w.l" in "rt_memclr.o". Please give us some suggestions.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 14, 2018

I have ran a simple "_memset()" test under the ci-test environment. The "_memset()" is not able to reset memory. The "_memset()" is defined from "c_w.l" in "rt_memclr.o". Please give us some suggestions.

I do not follow, might be worth having a separate issue for this? Is this blocking this PR?

I am not familiar with platform_stdlib.h that this issue relates to.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2018

A rebase is needed (the other realtek change caused a conflict here)

theotherjimmy and others added 5 commits February 20, 2018 12:09
Some toolchains (GCC) may emit error messages with unicode symbols based on
the your localization settings. Instead of being passed to the user as is,
the unicode causes an exception.
Current behaviour ends up undefined when the constructor leaves early.
Now FilePath just discards leading slashes and otherwise asserts if the
path is bad.
sleep_manager_racecondition test fix for devices with low CPU clock

This RP contains fix for sleep_manager_racecondition test
for very slow devices (like NRF51). It fixes the test itself
as well as side effects of fix introduced in
 ARMmbed#5046 (us ticker: fix fire interrupt handling)

The idea of the test was to test race condition between main thread
and interrupt handler calling the same function.
To efficiently test this, each handler call should interrupt
main thread to make race more likely.
On very slow devices (like NRF51) when we set very low ticker period
(e.g less then 1000us for NRF51) there is no much time for thread scheduling.
On such slow devices, setting period to 500 us cause that
main thread is scheduled very rarely and only handler is
constantly called making test unreliable.
Fix introduced in ARMmbed#5046 (us ticker: fix fire interrupt handling)
changed fire_interrupt function implementation causing more
interrupt tailing thus even less time for main thread scheduling.
After introduction of ARMmbed#5046 (us ticker: fix fire interrupt handling)
when running sleep_manager_racecondition test on NRF51
(with ticker1.attach_us(&sleep_manager_locking_irq_test, 500);)
test is failing with timeout due to the fact that interrupt
handler is constantly called and main thread is never scheduled.
@prashantrar
Copy link
Contributor

Have merged with latest master

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2018

Have merged with latest master

Please rebase instead of the merge (the merge commit is unnecessary here)

@prashantrar
Copy link
Contributor

Ok ,should I undo the commit and rebase?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2018

Ok ,should I undo the commit and rebase?

Yes, please

mmahadevan108 and others added 14 commits February 22, 2018 07:30
…update-to-new-md-api

Revert "Update Mbed TLS HW acceleration partner code to new hashing API"
tools: Let unicode error messages through
…meclipse

Correct single file excludes for some exporters
- Support programming across sectors.
- Support program size not aligned to page size.
- Fix validations on sector erase.
retarget: Fix path behaviour without leading slash
…PC54628

LPC546XX: Add support for 220MHz core speed available on LPC54628
nrf5x: fix array overflow in gpio configuration code
…cecondition_test_fix

sleep_manager_racecondition test fix for devices with low CPU clock
Fix ci-test issues with ARM compiler
- fix section error, ARM compiler uses IRAM1.bss to calculate the heap size
- fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler
…ub.com/M-ichae-l/mbed-os into mbed_ci-test-fixed_rtl8195am_12/2/2018

# Conflicts:
#	targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/serial_api.c
@M-ichae-l
Copy link
Contributor Author

I have done the rebase.
Is there still any issues?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2018

I have done the rebase.

Thanks, however if you review the commits, your branch still contains some commits that should not be there

If rebase is being problematic, you can cherrypick your commit and reapply it to your branch (after you locally reset it for instance).

@M-ichae-l M-ichae-l closed this Feb 27, 2018
@M-ichae-l M-ichae-l deleted the mbed_ci-test-fixed_rtl8195am_12/2/2018 branch February 27, 2018 02:52
@sg- sg- removed the needs: work label Feb 27, 2018
@M-ichae-l M-ichae-l restored the mbed_ci-test-fixed_rtl8195am_12/2/2018 branch February 27, 2018 02:53
@M-ichae-l M-ichae-l deleted the mbed_ci-test-fixed_rtl8195am_12/2/2018 branch February 27, 2018 02:53
@M-ichae-l M-ichae-l mentioned this pull request Feb 27, 2018
1 task
@M-ichae-l
Copy link
Contributor Author

There was some issue with the branch I created, hence I have raised a new pull request #6226. I have closed this PR. Apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.