-
Notifications
You must be signed in to change notification settings - Fork 3k
rtl8195am - fix ci-test issues with ARM compiler #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtl8195am - fix ci-test issues with ARM compiler #6061
Conversation
…for irq (or output)
Fix ci-test issues with ARM compiler - fix section error, ARM compiler uses IRAM1.bss to calculate the heap size - fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler
--none-- |
/morph build |
Build : SUCCESSBuild number : 1109 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 788 |
/morph uvisor-test |
Test : SUCCESSBuild number : 917 |
@M-ichae-l Might be worth sharing what ci-test issues is this fixing Are these :
what ci-tests? |
@0xc0170 |
I have ran a simple "_memset()" test under the ci-test environment. The "_memset()" is not able to reset memory. The "_memset()" is defined from "c_w.l" in "rt_memclr.o". Please give us some suggestions. |
I do not follow, might be worth having a separate issue for this? Is this blocking this PR? I am not familiar with |
A rebase is needed (the other realtek change caused a conflict here) |
Some toolchains (GCC) may emit error messages with unicode symbols based on the your localization settings. Instead of being passed to the user as is, the unicode causes an exception.
Current behaviour ends up undefined when the constructor leaves early. Now FilePath just discards leading slashes and otherwise asserts if the path is bad.
sleep_manager_racecondition test fix for devices with low CPU clock This RP contains fix for sleep_manager_racecondition test for very slow devices (like NRF51). It fixes the test itself as well as side effects of fix introduced in ARMmbed#5046 (us ticker: fix fire interrupt handling) The idea of the test was to test race condition between main thread and interrupt handler calling the same function. To efficiently test this, each handler call should interrupt main thread to make race more likely. On very slow devices (like NRF51) when we set very low ticker period (e.g less then 1000us for NRF51) there is no much time for thread scheduling. On such slow devices, setting period to 500 us cause that main thread is scheduled very rarely and only handler is constantly called making test unreliable. Fix introduced in ARMmbed#5046 (us ticker: fix fire interrupt handling) changed fire_interrupt function implementation causing more interrupt tailing thus even less time for main thread scheduling. After introduction of ARMmbed#5046 (us ticker: fix fire interrupt handling) when running sleep_manager_racecondition test on NRF51 (with ticker1.attach_us(&sleep_manager_locking_irq_test, 500);) test is failing with timeout due to the fact that interrupt handler is constantly called and main thread is never scheduled.
Have merged with latest master |
Please rebase instead of the merge (the merge commit is unnecessary here) |
Ok ,should I undo the commit and rebase? |
Yes, please |
Signed-off-by: Mahesh Mahadevan <[email protected]>
Signed-off-by: Mahesh Mahadevan <[email protected]>
…update-to-new-md-api Revert "Update Mbed TLS HW acceleration partner code to new hashing API"
tools: Let unicode error messages through
…meclipse Correct single file excludes for some exporters
- Support programming across sectors. - Support program size not aligned to page size. - Fix validations on sector erase.
retarget: Fix path behaviour without leading slash
…PC54628 LPC546XX: Add support for 220MHz core speed available on LPC54628
nrf5x: fix array overflow in gpio configuration code
…cecondition_test_fix sleep_manager_racecondition test fix for devices with low CPU clock
FlashIAP driver modifications
Fix ci-test issues with ARM compiler - fix section error, ARM compiler uses IRAM1.bss to calculate the heap size - fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler
…ub.com/M-ichae-l/mbed-os into mbed_ci-test-fixed_rtl8195am_12/2/2018 # Conflicts: # targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/serial_api.c
I have done the rebase. |
Thanks, however if you review the commits, your branch still contains some commits that should not be there If rebase is being problematic, you can cherrypick your commit and reapply it to your branch (after you locally reset it for instance). |
There was some issue with the branch I created, hence I have raised a new pull request #6226. I have closed this PR. Apologies for the delay. |
Description
fix section error, ARM compiler uses IRAM1.bss to calculate the heap size
fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler
Status
READY
Migrations
NONE
Related PRs
NONE
Todos
NONE
Deploy notes
NONE
Steps to test or reproduce
NONE