rtl8195am - fix gpio toggle slow #6289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new api to clear whole sent blockwise message list
fix section error, ARM compiler uses IRAM1.bss to calculate the heap size fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler
Ameba has two memory blocks: SDRAM(2M) and SRAM(512KB). SRAM has better access performance than SDRAM. So some timing critical codes must be moved to SRAM. Debug for mbed-os issue ARMmbed#5778
0xc0170
reviewed
Mar 7, 2018
| #define __bss_sram_start__ Image$$RW_IRAM2$$ZI$$Base | ||
| #define __bss_sram_end__ Image$$RW_IRAM2$$ZI$$Limit | ||
| #define __bss_sram_start__ Image$$RW_IRAM1$$ZI$$Base | ||
| #define __bss_sram_end__ Image$$RW_IRAM1$$ZI$$Limit |
There was a problem hiding this comment.
This one commit contains few changes:
- moving bss sramd to ram1
- removing some text from sram1
- some changes in the sections regarding lwip, _api and other files
Should this be split into separate commmits , or all are related and what might be beneficial is to describe these changes in the commit message?
I am trying to understand how this fixes gpio and relates to all these changes here
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks, that explains it. Please always state dependencies in the description.
There was a problem hiding this comment.
Please rebase again, I can see the commits from master duplicated here
Small typo fixes in readme.md files
…_only NVStore: Enclose header file with DOXYGEN_ONLY option as well.
Allow build profiles to omit language entries
…rtl8195am rtl8195am: fix ARM section error
Update mbed-coap to version 4.3.0
Adding Laird BL652 as new target
Fix for Crash dump formatting issues and adding more info to crash dump
Ameba has two memory blocks: SDRAM(2M) and SRAM(512KB). SRAM has better access performance than SDRAM. So some timing critical codes must be moved to SRAM. Debug for mbed-os issue ARMmbed#5778
…-ichae-l/mbed-os into rtl8195am-fix-gpio-toggle-slow
M-ichae-l
added a commit
to M-ichae-l/mbed-os
that referenced
this pull request
Mar 12, 2018
Ameba has two memory blocks: SDRAM(2M) and SRAM(512KB). SRAM has better access performance than SDRAM. So some timing critical codes must be moved to SRAM. fix for mbed-os issue ARMmbed#5778 rebase for ARMmbed#6289
1 task
|
There was some issue with the branch I created, hence I have raised a new pull request #6326. I have closed this PR. Apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ameba has two memory blocks: SDRAM(2M) and SRAM(512KB). SRAM has better access performance than SDRAM. So some timing critical codes must be moved to SRAM.
fix for mbed-os issue #5778
Pull request type