Skip to content

[QSPI] Add support for several STM disco boards #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2018

Conversation

adustm
Copy link
Member

@adustm adustm commented Apr 13, 2018

Description

This pull request enables QSPI feature for several STM platforms
DISCO_L476VG
DISCO_F746NG
DISCO_F413ZH
DISCO_F469NI (some modifications versus current implementation)

(DISCO_L475VG_IOT01A is already supported in the feature-qspi branch)
(DISCO_F769NI and DISCO_L496AG are on going work, and will be pushed later in another PR)

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2018

Changes look good to me. I am not sure about first 2 commits (they are already on the branch aren't they) ? (Github does not even show them in the full diff here)
In case yes, can you please rebase, I'll trigger CI right away then

@adustm
Copy link
Member Author

adustm commented Apr 16, 2018

Hello @0xc0170
Could you detail, please ?

continuous-integration/jenkins/pr-head — This commit cannot be built

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2018

Error: mbed_retarget.cpp@218,0: #289: no instance of constructor “mbed::UARTSerial::UARTSerial” matches the argument list for NRF52840_DK , might be the recent rebase, investigating now

Not related to this PR

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2018

Can you please rebase? I pushed an update to resolve the bad rebase (the failing build builds locally).

@adustm adustm force-pushed the some_disco_boards branch from ab7ed15 to 4d50340 Compare April 16, 2018 13:37
@adustm
Copy link
Member Author

adustm commented Apr 16, 2018

@0xc0170

Can you please rebase? I pushed an update to resolve the bad rebase (the failing build builds locally).

Done.

I am not sure about first 2 commits (they are already on the branch aren't they) ?

You're right. I've removed them

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2018

Build : SUCCESS

Build number : 1760
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6638/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 17, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2018

@cmonr cmonr merged commit e0dcc21 into ARMmbed:feature-qspi Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants