Skip to content

M2351 RAM / ROM defines updated #8719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2018
Merged

M2351 RAM / ROM defines updated #8719

merged 2 commits into from
Nov 26, 2018

Conversation

deepikabhavnani
Copy link

Description

RAM/ROM sizes in tools were updated to report entire device size, and in M2351 they were used earlier to report secure/non-secure partition size.

M2351 files are updated to take full RAM/ROM device size and derive secure and non-secure partition size based on that.

Commit for this PR: cb51f191d33887bdafe1c21d4f1d6f7c02348e8c
Other commits are from PR : #8607

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Dependent on #8607

CC @ARMmbed/team-nuvoton

@deepikabhavnani deepikabhavnani requested a review from a team November 12, 2018 16:36
@adbridge
Copy link
Contributor

@deepikabhavnani could you please rebase this ?

@deepikabhavnani
Copy link
Author

Rebased

@deepikabhavnani
Copy link
Author

@ccli8 - Please review

@ccli8
Copy link
Contributor

ccli8 commented Nov 15, 2018

@deepikabhavnani I meet link error: Error: L6292E: Ignoring unknown attribute 'MBED_ROM_START' specified for region LR_IROM1. Checking the files below, it seems that MBED_ROM_START/MBED_ROM_SIZE are passed along to compiler, but not to liner.

BUILD/tests/NUMAKER_PFM_M2351/ARMC6/.profile-c
BUILD/tests/NUMAKER_PFM_M2351/ARMC6/.profile-cxx
BUILD/tests/NUMAKER_PFM_M2351/ARMC6/.profile-ld

@deepikabhavnani
Copy link
Author

@ccli8 - This PR is dependent on #8607. Did you apply this PR on #8607? It was working for me, I just rebased it on top of the master instead of #8607

@ccli8
Copy link
Contributor

ccli8 commented Nov 16, 2018

@deepikabhavnani After applying #8607, it is working. I have no other concern.

@deepikabhavnani
Copy link
Author

@ARMmbed/mbed-os-maintainers - This is also for 5.11

@cmonr
Copy link
Contributor

cmonr commented Nov 22, 2018

@ARMmbed/team-nuvoton Thoughts on the PR?

Restarting CI

@cmonr
Copy link
Contributor

cmonr commented Nov 22, 2018

Jumped the gun a bit. #8607 is still open.

@deepikabhavnani
Copy link
Author

deepikabhavnani commented Nov 22, 2018 •
edited
Loading

@ARMmbed/team-nuvoton Thoughts on the PR?

Comment was from team-nuvoton #8719 (comment)
Review and testing is done.

Deepika added 2 commits November 22, 2018 09:07
Update parition sizes in M2351 - based on ARMmbed#8607
1d8c00e 
RAM/ROM sizes in tools were updated to report entire device size, and in M2351
they were used earlier to report secure/non-secure partition size.

M2351 files are updated to take full RAM/ROM device size and derive secure
and non-secure partition size based on that.
Addressed review comments from team-nuvoton
c0981a3
@deepikabhavnani
Copy link
Author

Rebased on top of master

@bulislaw
Copy link
Member

What's the status? Does it need review from Nuvoton or are we happy and it's ready for ci?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

What's the status? Does it need review from Nuvoton or are we happy and it's ready for ci?

Reviewed via email, will go to CI

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2018

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 24, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 6
Build artifacts
Build logs

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2018

exporters failed for one non relevant target, restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2018

Exporters for only gcc arm are green but not reported back and updated pipeline :(

cc @OPpuolitaival

@0xc0170 0xc0170 merged commit 80e2c11 into ARMmbed:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1 risk: A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@deepikabhavnani @adbridge @ccli8 @cmonr @bulislaw @0xc0170 @mbed-ci @NirSonnenschein