Add low power implementations for CM3DS #8737
Conversation
|
Seems that I have a little more commits that I wanted to have originally, trying to fix that... Edit: Fixed |
This commit represents the first stage of the low power implementations that are required from Mbed 5.10 onwards. The LP ticker has been implemented using a CMSDK Dual Timer's both timers (HW prescaler needed to operate in the specified frequency domain), whereas the us ticker uses one CMSDK Timer. Besides the default hal implementations (lp_ticker.c and us_ticker.c), the CMSDK Dual Timer's native driver needed to be added. Change-Id: I0b16b93dfac7753bebf430a2ce77761cb9c43ee5 Signed-off-by: Bence Kaposzta <[email protected]>
This commit represents the second stage of the low power implementations that are required from Mbed 5.10 onwards. Besides the default hal implementations (rtc_api.c and sleep.c), the PL031 RTC's native driver needed to be added. Due to HW limitations in SSE-050 and the CM3DS, Deep Sleep couldn't be implemented, therefore it is functionally identical to Sleep (WFI). Change-Id: Ibed2bdb452f48c98024dc7ef07fb51a4425e0a80 Signed-off-by: Bence Kaposzta <[email protected]>
kapi90
force-pushed
the
cm3ds_lp_requirements
branch
from
da2f079 to
ee7cefc
Compare
NirSonnenschein
requested review from
a team
and removed request for
theotherjimmy
|
@ARMmbed/mbed-os-maintainers , who is the correct teach-lead to review this one? |
|
@kapi90 Can you share tests results for these additions? (should be part of it - "how was this tested") |
|
Hi @0xc0170 it passed Greentea in the beginning of September (it's been pending since then), but when I was trying to reproduce my logs yesterday I realized that some of the tests have changed, and I got 2 minor cases failing in the Sleep and RTC api, hopefully I'll find the cause soon and push the changes today. |
|
Appreciated 👍 will wait for the update. |
Change-Id: I3c687694ee924938ec08ea40d0ddbcaf20dd0a73
kapi90
force-pushed
the
cm3ds_lp_requirements
branch
from
cc69725 to
5dd6d19
Compare
|
2 macros needed to be updated in the Sleep API that caused the failures, I've attached my Greentea logs of all 4 new components. |
@kapi90 Fyi, in order to update a pull request branch, we suggest that the branch be rebased instead of merged. It's not a paticular problem for this PR because this is coming in during a feature release, just an fyi. |
|
Thanks for the heads up @cmonr, will definitely take this into account next time. |
|
@ARMmbed/mbed-os-hal Please review |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
|
Restarted CI (all are now pending) |
Description
This commit adds the low power implementations that are required from
Mbed 5.10 onwards. The LP ticker has been implemented using a CMSDK
Dual Timer's both timers (HW prescaler needed to operate in the
specified frequency domain), whereas the us ticker uses one CMSDK Timer.
Besides the default hal implementations (lp_ticker.c, us_ticker.c, rtc_api.c
and sleep.c), the CMSDK Dual Timer's and the PL031 RTC's native drivers needed
to be added.Due to HW limitations in SSE-050 and the CM3DS, Deep Sleep
couldn't be implemented, therefore it is functionally identical to Sleep (WFI).
Pull request type
@tamasolaszi @tkaman @ashok-rao @0xc0170