NRF52 serial fixes #8784

c1728p9 · 2018-11-17T00:17:05Z

Description

Fix a few serial problems on the NRF52:

Fix for dropped bytes when transmitting and receiving at the same time
@marcuschangarm's fix for serial writes
Fix for receiving data without sending data first

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

In nordic_nrf5_uart_event_handler if the events NRF_UARTE_EVENT_ENDRX and NRF_UARTE_EVENT_RXSTARTED become pending after the check for NRF_UARTE_EVENT_ENDRX but before the check for NRF_UARTE_EVENT_RXSTARTED the RX DMA buffers will be setup incorrectly by nordic_nrf5_uart_event_handler_rxstarted because active_bank hasn't been updated. This cause dropped and incorrect data. This patch fixes that problem by adding a second check for NRF_UARTE_EVENT_ENDRX after checking for NRF_UARTE_EVENT_RXSTARTED and skipping processing if NRF_UARTE_EVENT_ENDRX is set. The subsequent interrupt will process both in the correct order. This ensures that these events cannot be handled out of order and thus fixes the corruption.

Busy-wait before sending a charecter instead of after. If serial_writeable has been called first, the busy-wait loop will be skipped. Added initialization code to ensure NRF_UARTE_EVENT_TXDRDY is armed correctly.

When attaching an irq to serial call nordic_nrf5_serial_configure. This ensures the serial is ready to receive data at the correct baudrate.

cmonr · 2018-11-17T03:46:49Z

Interesting. Gonna do a whole bunch of test Test CI runs.

cmonr · 2018-11-17T03:46:55Z

/morph build

cmonr · 2018-11-17T03:51:00Z

/morph build

mbed-ci · 2018-11-17T08:03:40Z

Build : SUCCESS

Build number : 3660
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8784/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-11-17T08:03:40Z

Build : SUCCESS

Build number : 3660
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8784/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-11-17T10:49:56Z

Exporter Build : SUCCESS

Build number : 3268
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8784/

0xc0170 · 2018-11-19T14:07:58Z

Info: This PR has been re-bundled into a new rollup PR (#8800).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

0xc0170 · 2018-11-19T14:15:48Z

Reworking my rollup, this still needs work as I was told (needs:w ork now here)

Make the following enhancement: -Support serial port use without flow control -Prevent dropped bytes by updating flow control handling -Remove dead code Serial port use without flow control: In the prior implementation there was a window of time between reloading DMA buffers after a timeout where bytes could be dropped. This is because the uart needed to be turned off in order to flush the bytes in the DMA buffer. This change configures the DMA buffer to only receive one byte at a time so there is no need to disable the uart to flush it. After each byte is received the DMA transfer will be over so the transfer will never be partially complete and need flushing. Since the uart is always on it is safe to use it even without flow control. Prevent dropped bytes by updating flow control handling: To prevent dropped bytes due to high latency the flow control handling of the RTS line was configured to be asserted automatically by hardware after each byte. Once the CPU has read the byte and setup the next receive buffer the RTS line is deasserted to the transfer can continue. This ensure that when flow control is enabled data won't be lost due to interrupt latency. Remove dead code: With the above changes there is a lot of dead code, such as the timer handling code. This patch removes the code that is no longer used.

When the RX FIFO is nearly full use flow control to stop receiving data.

c1728p9 · 2018-11-20T01:26:20Z

I fixed all the issues I have seen so far. This should be ready for testing. With these new commits the NRF52 should work reliably without flow control if interrupt latency is good, and should work reliably regardless of interrupt latency if flow control is on.

kjbracey

Looks good to me. Removing the DMA config parameter altogether will be a compatibility glitch, but then anyone who was manually configuring it should be rechecking what parameters they need, if any, after the change - presumably default parameters should be solid now.

0xc0170 · 2018-11-20T10:21:15Z

/morph build

mbed-ci · 2018-11-20T11:48:06Z

Build : SUCCESS

Build number : 3682
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8784/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-11-20T13:15:16Z

Test : FAILURE

Build number : 3458
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8784/3458

0xc0170 · 2018-11-20T13:17:20Z

No NRF5x issue here, known tracked issues

mbed-ci · 2018-11-20T13:42:44Z

Exporter Build : FAILURE

Build number : 3285
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8784/

0xc0170 · 2018-11-20T15:14:33Z

EOFError error in the exporter CI

marcuschangarm · 2018-11-20T17:19:18Z

Thanks Russ! Look awesome! 😄

kjbracey · 2018-11-20T17:28:38Z

Kari and Veijo have been making positive noises about this+ESP8266+mbed client. I think it's cleared all our problems (in conjunction with Marcus's other PRs).

0xc0170 · 2018-11-21T11:54:39Z

/morph build

mbed-ci · 2018-11-21T12:36:31Z

Build : FAILURE

Build number : 3702
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8784/

0xc0170 · 2018-11-21T13:00:55Z

restarting

[DEBUG] Output: Fatal error: A1023E: File "/tmp/filesS8062" could not be opened: No such file or directory from IAR

/morph build

mbed-ci · 2018-11-21T14:59:35Z

Build : ABORTED

Build number : 3703
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8784/

When initializing serial disable all interrupts as some of these may have been enabled by a bootloader. This ensures that the NRF52 serial driver remains compatible with any bootloader version.

c1728p9 · 2018-11-21T22:32:57Z

Add a commit to fix backwards compatibility with older bootloaders

mbed-ci · 2018-11-22T02:57:09Z

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

c1728p9 and others added 3 commits November 16, 2018 17:30

Make serial_putc for NRF52 non-blocking

bb98ce0

Busy-wait before sending a charecter instead of after. If serial_writeable has been called first, the busy-wait loop will be skipped. Added initialization code to ensure NRF_UARTE_EVENT_TXDRDY is armed correctly.

Configure NRF52 uart on interrupt attach

21dd8e4

When attaching an irq to serial call nordic_nrf5_serial_configure. This ensures the serial is ready to receive data at the correct baudrate.

cmonr added the needs: review label Nov 17, 2018

cmonr requested review from studavekar, OPpuolitaival and a team November 17, 2018 03:46

cmonr approved these changes Nov 17, 2018

View reviewed changes

OPpuolitaival approved these changes Nov 19, 2018

View reviewed changes

0xc0170 approved these changes Nov 19, 2018

View reviewed changes

0xc0170 added needs: CI rollup PR release-version: 5.11.0-rc1 and removed needs: review labels Nov 19, 2018

0xc0170 mentioned this pull request Nov 19, 2018

Rollup PR: Rerun falsely-failed PRs for 5.11-RC1 #8800

Closed

0xc0170 added needs: work and removed rollup PR needs: CI labels Nov 19, 2018

c1728p9 added 2 commits November 19, 2018 19:21

Add flow control for RX FIFO filling

9ce3965

When the RX FIFO is nearly full use flow control to stop receiving data.

cmonr added the needs: CI label Nov 20, 2018

cmonr removed the needs: work label Nov 20, 2018

kjbracey approved these changes Nov 20, 2018

View reviewed changes

marcuschangarm mentioned this pull request Nov 20, 2018

Improve flow control on NRF52 #8748

Closed

Disable all NRF52 serial interrupts on init

4acdf70

When initializing serial disable all interrupts as some of these may have been enabled by a bootloader. This ensures that the NRF52 serial driver remains compatible with any bootloader version.

0xc0170 added ready for merge and removed needs: CI labels Nov 22, 2018

0xc0170 merged commit 60b5547 into ARMmbed:master Nov 22, 2018

0xc0170 removed the ready for merge label Nov 22, 2018

c1728p9 deleted the nrf52_serial_fixes branch November 26, 2018 15:18

dlfryar-zz mentioned this pull request Feb 26, 2019

nRF SDK15 and USB Support #7674

Closed

NRF52 serial fixes #8784

NRF52 serial fixes #8784

Uh oh!

Conversation

c1728p9 commented Nov 17, 2018

Description

Pull request type

Uh oh!

cmonr commented Nov 17, 2018

Uh oh!

cmonr commented Nov 17, 2018

Uh oh!

cmonr commented Nov 17, 2018

Uh oh!

mbed-ci commented Nov 17, 2018

Triggering tests

Uh oh!

mbed-ci commented Nov 17, 2018

Triggering tests

Uh oh!

mbed-ci commented Nov 17, 2018

Uh oh!

0xc0170 commented Nov 19, 2018

Uh oh!

0xc0170 commented Nov 19, 2018

Uh oh!

c1728p9 commented Nov 20, 2018

Uh oh!

kjbracey left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 20, 2018

Uh oh!

mbed-ci commented Nov 20, 2018

Triggering tests

Uh oh!

mbed-ci commented Nov 20, 2018

Uh oh!

0xc0170 commented Nov 20, 2018

Uh oh!

mbed-ci commented Nov 20, 2018

Uh oh!

0xc0170 commented Nov 20, 2018

Uh oh!

marcuschangarm commented Nov 20, 2018

Uh oh!

kjbracey commented Nov 20, 2018

Uh oh!

0xc0170 commented Nov 21, 2018

Uh oh!

mbed-ci commented Nov 21, 2018

Uh oh!

0xc0170 commented Nov 21, 2018

Uh oh!

mbed-ci commented Nov 21, 2018

Uh oh!

c1728p9 commented Nov 21, 2018

Uh oh!

mbed-ci commented Nov 22, 2018

Uh oh!

Uh oh!