Skip to content

MTB_ADV_WISE_1570: disable MPU code until target properly supported #8922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2018
Merged

MTB_ADV_WISE_1570: disable MPU code until target properly supported #8922

merged 1 commit into from
Dec 4, 2018

Conversation

juhoeskeli
Copy link
Contributor

Description

The target started HardFaulting since the MPU overhaul commit (1821d37). This was visible in cloud connectivity tests. This is a workaround which disables the MPU code for the target. A proper fix would be target specific routines.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@juhoeskeli
Copy link
Contributor Author

@0xc0170 @kjbracey-arm please take a look

Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to chase up a proper fix, of course. Create GitHub tracking issue for that?

(Wondering if maybe we could arrange a build warning for devices with MPU off, just to stop this sort of workaround being totally forgotten...)

@juhoeskeli
Copy link
Contributor Author

Found the actual bug and created PR for that: #8946

In case that is OK maybe we can close down this one.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

@juhoeskeli Thanks 👍

@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@cmonr cmonr merged commit f82014e into ARMmbed:master Dec 4, 2018
@juhoeskeli
Copy link
Contributor Author

@cmonr we don't actually need this in master anymore as #8946 fixed the problem. Do you want a new PR to re-enable the feature or how should it be done?

@cmonr
Copy link
Contributor

cmonr commented Dec 4, 2018

@juhoeskeli Ah, neat.

I think the best thing to do would be to make a branch that reverts this PR, then submit that PR. We can take it from there.

0xc0170 added a commit that referenced this pull request Dec 10, 2018
Revert "Merge pull request #8922 from juhoeskeli/wise_1570_mpu_disable"
cmonr pushed a commit that referenced this pull request Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants