-
Notifications
You must be signed in to change notification settings - Fork 3k
MTB_ADV_WISE_1570: disable MPU code until target properly supported #8922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@0xc0170 @kjbracey-arm please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to chase up a proper fix, of course. Create GitHub tracking issue for that?
(Wondering if maybe we could arrange a build warning for devices with MPU off, just to stop this sort of workaround being totally forgotten...)
Found the actual bug and created PR for that: #8946 In case that is OK maybe we can close down this one. |
@juhoeskeli Thanks 👍 |
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
@juhoeskeli Ah, neat. I think the best thing to do would be to make a branch that reverts this PR, then submit that PR. We can take it from there. |
Revert "Merge pull request #8922 from juhoeskeli/wise_1570_mpu_disable"
Description
The target started HardFaulting since the MPU overhaul commit (1821d37). This was visible in cloud connectivity tests. This is a workaround which disables the MPU code for the target. A proper fix would be target specific routines.
Pull request type