Skip to content

Revert "Merge pull request #8922 from juhoeskeli/wise_1570_mpu_disable" #9003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Revert "Merge pull request #8922 from juhoeskeli/wise_1570_mpu_disable" #9003

merged 1 commit into from
Dec 10, 2018

Conversation

juhoeskeli
Copy link
Contributor

Description

Re-enable MPU for target as the proper fix for target is now merged: #8946

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team December 7, 2018 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 7, 2018

@juhoeskeli, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@juhoeskeli
Copy link
Contributor Author

@cmonr please take a look, is this how you wanted this to be made?

Also, can this be in the next RC.

@cmonr cmonr requested a review from c1728p9 December 7, 2018 20:23
@cmonr
Copy link
Contributor

cmonr commented Dec 7, 2018

@juhoeskeli Looks good to me. Will see what we can do to get it in RC3.

is this how you wanted this to be made?

Could you provide the context for this part of the senetence? I'm afraid I'm not following.

@c1728p9 This would reenabled the MPU for a target. Please advise.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2018

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2018

Restarted cloud client test, there was a connection error

@mbed-ci
Copy link

mbed-ci commented Dec 10, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2018

@ARMmbed/mbed-os-test-team The failure for cloud client test, can you review? There's teardown exception happening.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2018

@ARMmbed/mbed-os-test-team The failure for cloud client test, can you review? There's teardown exception happening.

It's now green, was it connection problems with CI?

@0xc0170 0xc0170 merged commit 40e13cf into ARMmbed:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants