-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32L4: before calling HAL_CRYP_DeInit initialize the Instance member #8946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@0xc0170 please take a look |
@ARMmbed/team-st-mcd we would like to take this to the 5.11-rc2 (labeled as such), can you please review ? |
Nice catch |
Travis failure will be fixed on master soon (we will request rebase once done). See #8945 |
The fix is on master, if you rebase, it should allow travis to run |
Done rebasing |
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
Tested with wise 1570 (STM32L4) & cloud client. When function aes_set_key is called the function HAL_CRYP_DeInit calls macro __HAL_CRYP_DISABLE which dereferences null pointer (Instance). The target ends up HardFaulting. The issue was uncovered by the MPU overhaul change which was recently introduced.
To fix this, the Instance member should be initialized before calling HAL_CRYP_DeInit. This fixes the issue for workaround #8922.
Pull request type