-
Notifications
You must be signed in to change notification settings - Fork 3k
Nuvoton: Support boot stack size configuration option #9102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuvoton: Support boot stack size configuration option #9102
Conversation
@ccli8, thank you for your changes. |
cc @mprse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good.
I'm also working on boot stack size (PR #9092). Probably I will divide my PR and add commit for each Vendor. So I can remove Nuvoton from my PR since probably this one will be merged faster.
I have one request. Can you provide results of the following tests:
- tests-mbed_hal-stack_size_unification (5ffe000)
- tests-mbedmicro-rtos-mbed-heap_and_stack
…fication NANO130 just has 16 KiB SRAM. User application may change it through "rtos.main-thread-stack-size" configuration option.
NANO130+ARM
NANO130+GCC_ARM
NANO130+IAR
|
NUC472+ARM
NUC472+GCC_ARM
NUC472+IAR
|
M453+ARM
M453+GCC_ARM
M453+IAR
|
M487+ARM
M487+GCC_ARM
M487+IAR
|
M2351+ARMC6Currently, only ARMC6 is supported on M2351.
|
@mprse As above, I list the test results on Nuvoton targets. |
CI started |
After changing the stack size of main thread, other test might fail in CI of NANO130, we do not have this hardware in CI so please test this locally |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@mprse @ccli8 Looks like I missed this comment: #9102 (comment) Please open an issue if problems with this PR are found. If the issues end up being severe, we can revert this PR. |
Description
Based on #8039, this PR adds support for target configuration option
target.boot-stack-size
for configuring interrupt stack size in mbed-os 5 and main stack size in mbed-os 2.Support targets
Pull request type