Skip to content

Nuvoton: Support boot stack size configuration option #9102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Dec 14, 2018

Description

Based on #8039, this PR adds support for target configuration option target.boot-stack-size for configuring interrupt stack size in mbed-os 5 and main stack size in mbed-os 2.

Support targets

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487
  • NUMAKER_PFM_M2351

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team December 14, 2018 12:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2018

cc @mprse

@0xc0170 0xc0170 requested a review from mprse December 14, 2018 14:14
Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good.

I'm also working on boot stack size (PR #9092). Probably I will divide my PR and add commit for each Vendor. So I can remove Nuvoton from my PR since probably this one will be merged faster.
I have one request. Can you provide results of the following tests:

  • tests-mbed_hal-stack_size_unification (5ffe000)
  • tests-mbedmicro-rtos-mbed-heap_and_stack

…fication

NANO130 just has 16 KiB SRAM. User application may change it through "rtos.main-thread-stack-size"
configuration option.
@ccli8
Copy link
Contributor Author

ccli8 commented Dec 18, 2018

@mprse NUMAKER_PFM_NANO130 cannot pass tests-mbed_hal-stack_size_unification because it configures main thread stack size to 3092. Now I remove the configuration in 28b820f for stack size unification.

@ccli8
Copy link
Contributor Author

ccli8 commented Dec 18, 2018

NANO130+ARM

mbedgt: test case report:
+-------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                  | platform_name       | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+-------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.02               |
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+-------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

NANO130+GCC_ARM

mbedgt: test case report:
+-----------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                      | platform_name       | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+-----------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_NANO130-GCC_ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-GCC_ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.02               |
| NUMAKER_PFM_NANO130-GCC_ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-GCC_ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-GCC_ARM | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+-----------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

NANO130+IAR

mbedgt: test case report:
+-------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                  | platform_name       | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+-------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_NANO130-IAR | NUMAKER_PFM_NANO130 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-IAR | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.02               |
| NUMAKER_PFM_NANO130-IAR | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-IAR | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NANO130-IAR | NUMAKER_PFM_NANO130 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+-------------------------+---------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

@ccli8
Copy link
Contributor Author

ccli8 commented Dec 18, 2018

NUC472+ARM

mbedgt: test case report:
+------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                 | platform_name      | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.88               |
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

NUC472+GCC_ARM

mbedgt: test case report:
+----------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                     | platform_name      | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+----------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.9                |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+----------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

NUC472+IAR

mbedgt: test case report:
+------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                 | platform_name      | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_NUC472-IAR | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-IAR | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.61               |
| NUMAKER_PFM_NUC472-IAR | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-IAR | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_NUC472-IAR | NUMAKER_PFM_NUC472 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+------------------------+--------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

@ccli8
Copy link
Contributor Author

ccli8 commented Dec 18, 2018

M453+ARM

mbedgt: test case report:
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target               | platform_name    | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.02               |
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

M453+GCC_ARM

mbedgt: test case report:
+--------------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                   | platform_name    | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+--------------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.01               |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+--------------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

M453+IAR

mbedgt: test case report:
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target               | platform_name    | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.02               |
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

@ccli8
Copy link
Contributor Author

ccli8 commented Dec 18, 2018

M487+ARM

mbedgt: test case report:
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target               | platform_name    | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.04               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

M487+GCC_ARM

mbedgt: test case report:
+--------------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                   | platform_name    | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+--------------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.05               |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+--------------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

M487+IAR

mbedgt: test case report:
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target               | platform_name    | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M487-IAR | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-IAR | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.03               |
| NUMAKER_PFM_M487-IAR | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-IAR | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.0                |
| NUMAKER_PFM_M487-IAR | NUMAKER_PFM_M487 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.0                |
+----------------------+------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

@ccli8
Copy link
Contributor Author

ccli8 commented Dec 18, 2018

M2351+ARMC6

Currently, only ARMC6 is supported on M2351.

mbedgt: test case report:
+-------------------------+-------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                  | platform_name     | test suite                                       | test case                     | passed | failed | result | elapsed_time (sec) |
+-------------------------+-------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M2351-ARMC6 | NUMAKER_PFM_M2351 | mbed-os-tests-mbed_hal-stack_size_unification    | Stack size unification test   | 1      | 0      | OK     | 0.06               |
| NUMAKER_PFM_M2351-ARMC6 | NUMAKER_PFM_M2351 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap allocation and free | 1      | 0      | OK     | 0.13               |
| NUMAKER_PFM_M2351-ARMC6 | NUMAKER_PFM_M2351 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test heap in range            | 1      | 0      | OK     | 0.06               |
| NUMAKER_PFM_M2351-ARMC6 | NUMAKER_PFM_M2351 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test isr stack in range       | 1      | 0      | OK     | 0.07               |
| NUMAKER_PFM_M2351-ARMC6 | NUMAKER_PFM_M2351 | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack | Test main stack in range      | 1      | 0      | OK     | 0.05               |
+-------------------------+-------------------+--------------------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 5 OK

@ccli8
Copy link
Contributor Author

ccli8 commented Dec 18, 2018

@mprse As above, I list the test results on Nuvoton targets.

@mprse
Copy link
Contributor

mprse commented Dec 18, 2018

@mprse As above, I list the test results on Nuvoton targets.

Looks great! Thanks for all this changes and test results. I will remove Nuvoton changes from my PR when this one is merged.
@0xc0170 I think we can start CI.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2018

CI started

@deepikabhavnani
Copy link

@mprse NUMAKER_PFM_NANO130 cannot pass tests-mbed_hal-stack_size_unification because it configures main thread stack size to 3092. Now I remove the configuration in 28b820f for stack size unification.

After changing the stack size of main thread, other test might fail in CI of NANO130, we do not have this hardware in CI so please test this locally

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 187d2d0 into ARMmbed:master Dec 18, 2018
@cmonr
Copy link
Contributor

cmonr commented Dec 18, 2018

@mprse @ccli8 Looks like I missed this comment: #9102 (comment)

Please open an issue if problems with this PR are found. If the issues end up being severe, we can revert this PR.

@cyliangtw cyliangtw deleted the nuvoton_support_boot_stack_option branch March 9, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants