Skip to content

Update websites-preview with latest from preview branch #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 249 commits into from
Jan 6, 2018

Conversation

markcowl
Copy link
Member

@markcowl markcowl commented Jan 5, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

maddieclayton
maddieclayton previously approved these changes Jan 5, 2018
Add tests for Compute cmdlets with -AsJob parameter
markcowl and others added 6 commits January 5, 2018 11:43
Add -AsJob parameter to Storage cmdlets
Add -AsJob parameter to long running Network cmdlets
Stack: Consuming IStorageContext and IStorageServiceProvider in Azure.storage, AzureRM.Storage and AzureRm.Compute modules, adding checkin test for Azure.Storage and AzureRm.Storage modules
Fix example in Remove-AzureRmVMSecret
Removed local NuGet package that was causing build issues for KeyVault on the Stack solution
@markcowl markcowl merged commit 51cfa61 into websites-preview Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.