Skip to content

#2268 Correct a version calculation for non-master mainline branches #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2020

Conversation

Kirill-Maurin
Copy link
Contributor

Fixes #2268

@Kirill-Maurin Kirill-Maurin force-pushed the bugfix/2268 branch 4 times, most recently from 4051a6f to fc2bb64 Compare May 11, 2020 17:51
@arturcic arturcic requested a review from asbjornu May 11, 2020 18:18
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple typo. Otherwise this is good to go. :)

@Kirill-Maurin
Copy link
Contributor Author

Just a simple typo. Otherwise this is good to go. :)

Done

@Kirill-Maurin Kirill-Maurin requested a review from asbjornu May 12, 2020 09:27
@asbjornu
Copy link
Member

@Kirill-Maurin, looking good! Do you want to do a rebase or should I just merge from master?

@arturcic
Copy link
Member

@asbjornu let's merge it and we can release 5.3.3

@asbjornu asbjornu merged commit 7bc6695 into GitTools:master May 12, 2020
@asbjornu asbjornu added this to the 5.3.3 milestone May 12, 2020
@asbjornu
Copy link
Member

Thank you for your contributions, @Kirill-Maurin! 🙏

@arturcic arturcic removed this from the 5.3.3 milestone May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect version calculation for non-master mainline
3 participants