Skip to content

feat: NetworkObject parenting, PickUp Action [MTT-992] #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Aug 23, 2022

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Sep 29, 2021

Description

This PR introduces the "PickUp" and "Drop" ability for all players. The action is triggered through contextual targeting of "Heavy" pots, and goes through the Action system. A pot has been added to the start of the entrance area. Pots parented to players that disconnect will be unparented through Netcode.

A pot is parented to the root of the PlayerAvatar GameObject, and the PositionConstraint component is used to follow the position of a hand bone.

As this is the first, non-visual iteration of the action, a follow-up PR will include the final UI images for the actions, as well as any supplementary visuals for pickup and dropping.

Issue Number(s)

MTT-992

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added 1-Needs Review PR needs attention from the assignee and reviewers type:feature New feature, request or improvement labels Sep 29, 2021
Copy link
Contributor

@VALERE91Unity VALERE91Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, CustomParentingHandler is meant to disappear right? Otherwise I would recommend implement error logs on all your if.

VALERE91Unity
VALERE91Unity previously approved these changes Sep 29, 2021
@SamuelBellomo SamuelBellomo added 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 21, 2021
@SamuelBellomo
Copy link
Contributor

I've put this on hold for now and added something on our calendars to come back to this.

@SamuelBellomo
Copy link
Contributor

After coming back to this, we'll need a refactor to our player structure before this gets in

@SamuelBellomo SamuelBellomo removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Nov 23, 2021
@SamuelBellomo SamuelBellomo removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Jul 11, 2022
@fernando-cortez fernando-cortez added 1-Needs Review PR needs attention from the assignee and reviewers and removed 2-Reviewed with Comments PR requires owner's attention labels Jul 26, 2022
@fernando-cortez fernando-cortez changed the title feat: NetworkObject parenting, PickUp Action feat: NetworkObject parenting, PickUp Action [MTT-992] Aug 22, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Aug 23, 2022
Co-authored-by: Sam Bellomo <[email protected]>
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 23, 2022
@fernando-cortez fernando-cortez merged commit 7729098 into develop Aug 23, 2022
@fernando-cortez fernando-cortez deleted the feature/networkobject-parenting branch August 23, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-Good to Merge type:feature New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants