-
Notifications
You must be signed in to change notification settings - Fork 557
feat: NetworkObject parenting, PickUp Action [MTT-992] #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Assets/BossRoom/Scripts/Server/Game/Entity/ServerRemoveChildrenOnFaint.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Server/Game/Entity/ServerDisplacerOnParentChange.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Shared/Game/Entity/CustomParentingHandler.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, CustomParentingHandler is meant to disappear right? Otherwise I would recommend implement error logs on all your if.
Assets/BossRoom/Scripts/Shared/Game/Entity/CustomParentingHandler.cs
Outdated
Show resolved
Hide resolved
I've put this on hold for now and added something on our calendars to come back to this. |
After coming back to this, we'll need a refactor to our player structure before this gets in |
Assets/Scripts/Gameplay/GameplayObjects/ServerDropItemOnFaint.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Bellomo <[email protected]>
Description
This PR introduces the "PickUp" and "Drop" ability for all players. The action is triggered through contextual targeting of "Heavy" pots, and goes through the Action system. A pot has been added to the start of the entrance area. Pots parented to players that disconnect will be unparented through Netcode.
A pot is parented to the root of the PlayerAvatar GameObject, and the
PositionConstraint
component is used to follow the position of a hand bone.As this is the first, non-visual iteration of the action, a follow-up PR will include the final UI images for the actions, as well as any supplementary visuals for pickup and dropping.
Issue Number(s)
MTT-992
Contribution checklist