-
Notifications
You must be signed in to change notification settings - Fork 560
feat: simpler quitting flow #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now specifies that it should only quit the game on the prefab inside the MainMenu scene, otherwise always calls LeaveSession()
pdeschain
requested changes
Mar 23, 2022
pdeschain
previously approved these changes
Mar 29, 2022
fernando-cortez
requested changes
Mar 30, 2022
fernando-cortez
previously approved these changes
Mar 30, 2022
SamuelBellomo
previously approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go once we've solved the other conversation
9cf8036
fernando-cortez
previously approved these changes
Mar 31, 2022
pdeschain
reviewed
Apr 4, 2022
Assets/BossRoom/Scripts/Shared/Game/State/GameStateBehaviour.cs
Outdated
Show resolved
Hide resolved
pdeschain
reviewed
Apr 4, 2022
Assets/BossRoom/Scripts/Shared/Game/State/GameStateBehaviour.cs
Outdated
Show resolved
Hide resolved
pdeschain
reviewed
Apr 4, 2022
Assets/BossRoom/Scripts/Shared/Game/State/GameStateBehaviour.cs
Outdated
Show resolved
Hide resolved
pdeschain
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
4 tasks
fernando-cortez
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR implements the same feature as #537 did, but without checking scene names in code. To do this, the SettingsPanelCanvas is removed from the DDOL scene, and added to every scene. An enum field in QuitPanel decides if we want to return to the menu, or quit the application, so each scene can specify the expected behavior. In this case, in every scene except the MainMenu, we return to the menu when using the quit button, and in the MainMenu scene, we quit the application.
This PR also extracts the DI scope initialization and injection from ClientMainMenuState and ClientCharSelectState to their parent GameStateBehavior. Now every state has a specific scope and a serialized fields for GameObjects in which to inject.
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT-2919
Manual testing scenarios
Questions or comments
Contribution checklist