-
Notifications
You must be signed in to change notification settings - Fork 557
feat: adding NetworkSimulator [MTT-6084] [MTT-6083] #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit 7f058d3)
(cherry picked from commit f94a791)
* Can change preset via dropdown (cherry picked from commit 0275af1)
(cherry picked from commit 4b9c7c6)
(cherry picked from commit 61f6be6)
(cherry picked from commit c4f798e)
(cherry picked from commit 3f95398)
(cherry picked from commit 2f916ff)
(cherry picked from commit ae5c308)
(cherry picked from commit 7d79d78)
(cherry picked from commit fab6f5c)
(cherry picked from commit a8e0adb)
(cherry picked from commit a08d5ab)
…m window (cherry picked from commit f0ad3c9)
(cherry picked from commit 97a669a)
(cherry picked from commit 92f6e23)
Can you link here the ticket for the bug encountered inside of #841? Or maybe mention it inside the summary? Looks good otherwise. |
We are not yet sure it is a bug. I'll wait until discussing with the tools team tomorrow before creating the ticket. I'll adjust the summary though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the visuals, here's how they look: 2023-06-09.15-51-51.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, glad you found a way to populate the Configurations
collection, I missed noticing that it was a ICollection
instead of a IReadOnlyCollection
.
I just added a minor suggestion that should improve the code, but it's not a blocker.
Description
This PR adds the NetworkSimulator tool to Boss Room. It can be used in the editor through the inspector, as by default, or through a new popup window which exposes some of its functionality. This window is accessible in development builds.
This PR also updates UTP to version 2.0.2, since version 2.0.0 and above is a requirement of NetworkSimulator.
This PR is based on PRs #841 and #835.
Issue Number(s)
MTT-6084 & MTT-6083
Contribution checklist