Skip to content

feat: adding NetworkSimulator [MTT-6084] [MTT-6083] #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jun 13, 2023

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Jun 7, 2023

Description

This PR adds the NetworkSimulator tool to Boss Room. It can be used in the editor through the inspector, as by default, or through a new popup window which exposes some of its functionality. This window is accessible in development builds.
This PR also updates UTP to version 2.0.2, since version 2.0.0 and above is a requirement of NetworkSimulator.

This PR is based on PRs #841 and #835.

Issue Number(s)

MTT-6084 & MTT-6083

Contribution checklist

  • [n/a] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

(cherry picked from commit 7f058d3)
(cherry picked from commit fd07a38)
(cherry picked from commit f94a791)
* Can change preset via dropdown

(cherry picked from commit 0275af1)
(cherry picked from commit 61f6be6)
(cherry picked from commit ae5c308)
(cherry picked from commit 7d79d78)
(cherry picked from commit fab6f5c)
(cherry picked from commit a8e0adb)
(cherry picked from commit a08d5ab)
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers 2-hard This PR requires 2 reviewers labels Jun 7, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review June 7, 2023 17:46
fernando-cortez
fernando-cortez previously approved these changes Jun 7, 2023
@fernando-cortez
Copy link
Collaborator

Can you link here the ticket for the bug encountered inside of #841? Or maybe mention it inside the summary? Looks good otherwise.

@LPLafontaineB
Copy link
Contributor Author

Can you link here the ticket for the bug encountered inside of #841? Or maybe mention it inside the summary? Looks good otherwise.

We are not yet sure it is a bug. I'll wait until discussing with the tools team tomorrow before creating the ticket. I'll adjust the summary though

Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some visual updates to the network simulator! Here are some screenshots:

image

image

fernando-cortez
fernando-cortez previously approved these changes Jun 9, 2023
@jilfranco-unity
Copy link
Contributor

updated the visuals, here's how they look:

2023-06-09.15-51-51.mp4

DenninDalke
DenninDalke previously approved these changes Jun 9, 2023
Copy link

@DenninDalke DenninDalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, glad you found a way to populate the Configurations collection, I missed noticing that it was a ICollection instead of a IReadOnlyCollection.

I just added a minor suggestion that should improve the code, but it's not a blocker.

@LPLafontaineB LPLafontaineB merged commit 52ae6a6 into develop Jun 13, 2023
@LPLafontaineB LPLafontaineB deleted the feat/adding-netsim-v2 branch June 13, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-hard This PR requires 2 reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants