Skip to content

fix(javascript): ensure requesters work as in v4 #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2022
Merged

fix(javascript): ensure requesters work as in v4 #823

merged 2 commits into from
Jul 21, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jul 13, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-588

Changes included:

The goal of this PR is to import requester related tests implemented in v4 to ensure we did not broke it when refactoring.

Changes in this PR:

  • Import requester tests from v4, they are 1:1 the same, except some syntax changes
    • I've kept the server logic in the test files, but it will be moved at the monorepo level later to be able to do similar tests on the CTS
    • Some of those tests should also disappear once we have the e2e CTS in place, but can be done in parallel
  • Fix wrong requester.send signature that was made compliant for the echoRequester
  • Add some type definition + re-use types

Next

Ensure body is correct in POST and DELETE methods

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Jul 13, 2022
@netlify
Copy link

netlify bot commented Jul 13, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit cbebf3c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62d918d55a3f970008cad87f

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 13, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts changed the title fix(javascript): ensure requesters work as in v4 fix(javascript): fix send method signature, ensure requesters works with v4 tests Jul 13, 2022
@shortcuts shortcuts force-pushed the fix/javascript-requester branch from 137e799 to 1630fad Compare July 18, 2022 14:09
@shortcuts shortcuts mentioned this pull request Jul 18, 2022
Merged
@shortcuts shortcuts force-pushed the fix/javascript-requester branch from 1630fad to 4af574e Compare July 18, 2022 14:26
@shortcuts shortcuts changed the base branch from main to fix/clients-empty-body-request July 18, 2022 14:26
@shortcuts shortcuts force-pushed the fix/clients-empty-body-request branch from 9b758b5 to eca2fc5 Compare July 18, 2022 16:12
@shortcuts shortcuts force-pushed the fix/javascript-requester branch 2 times, most recently from 3b2035c to 70a8029 Compare July 19, 2022 07:39
@shortcuts shortcuts force-pushed the fix/clients-empty-body-request branch 2 times, most recently from 94464cc to bfc99ff Compare July 20, 2022 14:48
@shortcuts shortcuts force-pushed the fix/javascript-requester branch from 70a8029 to 792e5c2 Compare July 20, 2022 16:12
@shortcuts shortcuts changed the title fix(javascript): fix send method signature, ensure requesters works with v4 tests fix(javascript): ensure requesters work as in v4 Jul 20, 2022
Base automatically changed from fix/clients-empty-body-request to main July 20, 2022 16:17
@shortcuts shortcuts force-pushed the fix/javascript-requester branch from 792e5c2 to 027bf0e Compare July 20, 2022 16:29
@shortcuts shortcuts requested review from a team, damcou and millotp and removed request for a team July 20, 2022 16:30
@shortcuts shortcuts marked this pull request as ready for review July 20, 2022 16:30
millotp
millotp reviewed Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests are looking good ! just a few comments on english, nothing important

@shortcuts shortcuts requested a review from millotp July 21, 2022 09:14
millotp
millotp approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@shortcuts shortcuts merged commit da6474f into main Jul 21, 2022
@shortcuts shortcuts deleted the fix/javascript-requester branch July 21, 2022 09:41
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 21, 2022
@algolia-bot @shortcuts
fix(javascript): ensure requesters work as in v4
9b291b6 
algolia/api-clients-automation#823

Co-authored-by: Clément Vannicatte <[email protected]>
@millotp millotp mentioned this pull request Mar 8, 2023
Closed
medicindev pushed a commit to medicindev/Algolia-Client--JavaScript that referenced this pull request Mar 8, 2025
@algolia-bot @shortcuts
fix(javascript): ensure requesters work as in v4
95af4d2 
algolia/api-clients-automation#823

Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp