@@ -159,16 +159,6 @@ def karma_web_test_suite(name, **kwargs):
159
159
kwargs ["srcs" ] = ["@npm//:node_modules/tslib/tslib.js" ] + getAngularUmdTargets () + kwargs .get ("srcs" , [])
160
160
kwargs ["deps" ] = ["//tools/rxjs:rxjs_umd_modules" ] + kwargs .get ("deps" , [])
161
161
162
- # Set up default browsers if no explicit `browsers` have been specified.
163
- if not hasattr (kwargs , "browsers" ):
164
- kwargs ["tags" ] = ["native" ] + kwargs .get ("tags" , [])
165
- kwargs ["browsers" ] = [
166
- # Note: when changing the browser names here, also update the "yarn test"
167
- # script to reflect the new browser names.
168
- "@npm_angular_dev_infra_private//browsers:chromium" ,
169
- "@io_bazel_rules_webtesting//browsers:firefox-local" ,
170
- ]
171
-
172
162
for opt_name in kwargs .keys ():
173
163
# Filter out options which are specific to "karma_web_test" targets. We cannot
174
164
# pass options like "browsers" to the local web test target.
@@ -204,11 +194,10 @@ def karma_web_test_suite(name, **kwargs):
204
194
def protractor_web_test_suite (flaky = True , ** kwargs ):
205
195
_protractor_web_test_suite (
206
196
flaky = flaky ,
207
- browsers = ["@npm_angular_dev_infra_private//browsers:chromium" ],
208
197
** kwargs
209
198
)
210
199
211
- def ng_web_test_suite (deps = [], static_css = [], bootstrap = [], ** kwargs ):
200
+ def ng_web_test_suite (deps = [], static_css = [], bootstrap = [], tags = [], ** kwargs ):
212
201
# Always include a prebuilt theme in the test suite because otherwise tests, which depend on CSS
213
202
# that is needed for measuring, will unexpectedly fail. Also always adding a prebuilt theme
214
203
# reduces the amount of setup that is needed to create a test suite Bazel target. Note that the
@@ -252,6 +241,12 @@ def ng_web_test_suite(deps = [], static_css = [], bootstrap = [], **kwargs):
252
241
deps = [
253
242
"//test:angular_test_init" ,
254
243
] + deps ,
244
+ browsers = [
245
+ # Note: when changing the browser names here, also update the "yarn test"
246
+ # script to reflect the new browser names.
247
+ "@io_bazel_rules_webtesting//browsers:chromium-local" ,
248
+ "@io_bazel_rules_webtesting//browsers:firefox-local" ,
249
+ ],
255
250
bootstrap = [
256
251
# This matches the ZoneJS bundles used in default CLI projects. See:
257
252
# https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/application/files/src/polyfills.ts.template#L58
@@ -265,5 +260,6 @@ def ng_web_test_suite(deps = [], static_css = [], bootstrap = [], **kwargs):
265
260
"@npm//:node_modules/zone.js/dist/zone-testing.js" ,
266
261
"@npm//:node_modules/reflect-metadata/Reflect.js" ,
267
262
] + bootstrap ,
263
+ tags = ["native" ] + tags ,
268
264
** kwargs
269
265
)
0 commit comments