Skip to content

build: fix ci failures in patch branch #19607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

devversion
Copy link
Member

@devversion devversion commented Jun 11, 2020

This reverts commit b4d0852 in the 9.2.x branch. This commit relied on a more recent version of the dev-infra package that is currently not installed in 9.2.x. i.e. the new browser repositories for the dev-infra package are not configured or available in the installed dev-infra package version.

Also reverts 771b4ba as that one relied on a MDC version update that is not part of the patch branch.

@devversion devversion requested review from jelbourn and a team as code owners June 11, 2020 12:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 11, 2020
…test canary release (angular#19548)"

This reverts commit 771b4ba.

This has been accidentally merged into the patch branch, where the MDC
version has not been updated yet.
@devversion devversion requested a review from crisbeto as a code owner June 11, 2020 12:57
@devversion devversion changed the title build: revert dev-infra chromium browser deduplication [patch only] build: fix ci failures in patch branch Jun 11, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 11, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added merge safe target: patch This PR is targeted for the next patch release labels Jun 11, 2020
@andrewseguin andrewseguin merged commit 1e94871 into angular:9.2.x Jun 11, 2020
andrewseguin pushed a commit that referenced this pull request Jun 11, 2020
* Revert "build: switch to chromium provided in dev-infra package (#19565)"

This reverts commit b4d0852.

* Revert "fix(material-experimental/mdc-menu): missing padding after latest canary release (#19548)"

This reverts commit 771b4ba.

This has been accidentally merged into the patch branch, where the MDC
version has not been updated yet.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants