build: ensure components can be built with ivy strict template type checking #16373

devversion · 2019-06-24T20:08:02Z

No description provided.

src/cdk/stepper/stepper.ts

src/dev-app/checkbox/checkbox-demo.ts

src/dev-app/datepicker/datepicker-demo.ts

jelbourn · 2019-06-24T22:03:26Z

src/dev-app/datepicker/datepicker-demo.html

-    <input matInput [matDatepicker]="datePicker4" [value]="date" [min]="minDate"
-           [max]="maxDate" [matDatepickerFilter]="filterOdd ? dateFilter : null">
+      <!--
+        TODO for reviewer: Angular sets the inputs for both directives on the


We'll need to talk about this at the framework meeting

Was there an outcome from the discussion of this at the framework meeting? This is an issue that I'm still running into and I don't have a solution.

jelbourn · 2019-06-24T22:03:58Z

src/dev-app/connected-overlay/connected-overlay-demo.html

@@ -97,7 +97,7 @@ <h2>Options</h2>
  <button mat-raised-button
      cdkOverlayOrigin
      type="button"
-      [disabled]="overlayRef"
+      [disabled]="!!overlayRef"


Let's talk about this one at the team meeting

For this one I'm not sure if there is actually an issue? With strict type checking it makes sense to me that it expects a boolean here and not an overlay ref (even though it is truthy). example

jelbourn · 2019-06-24T22:04:03Z

src/dev-app/datepicker/datepicker-demo.html

@@ -51,7 +51,7 @@ <h2>Result</h2>
           [(ngModel)]="date"
           [min]="minDate"
           [max]="maxDate"
-           [matDatepickerFilter]="filterOdd ? dateFilter : null"
+           [matDatepickerFilter]="filterOdd ? dateFilter : undefined"


Let's talk about this one at the team meeting

To provide some context for later:

@Input() set matDatepickerFilter(value: (date: D | null) => boolean) {

With strict null checks, type checking should technically complain for both undefined and null. Right now it looks like with ngtsc type checking, undefined is somehow allowed while null is not.

Chatted with Joost and it looks like it is because ngtsc uses Partial for checking the input bindings. This means that undefined is a valid value. To me this looks like a bug because explicitly assigning it to undefined vs not even setting the input is a difference. Related code: see here

src/material-examples/tab-group-async/tab-group-async-example.html

…pe checking Before angular#15134 landed, the stepper accepted an`AbstractControl` from `@angular/forms`. Unfortunately this PR accidentally changed the type for the `stepControl` input from `AbstractControl` to `FormControl`. This means that with strict template type checking, passing a `FormGroup` (like we do in our dev-app various times) causes type check failures. We need to adjust the `stepControl` type to accept an abstract control which is the base of a `FormControl` and `FormmGroup`.

All components which are exported should be built with Ivy's strict template type checking. This guarantees maximum safety for template bindings and increases general code health in the components repository.

…ecking

Splaktar · 2019-10-15T20:11:51Z

I think that the main blockers of this have been resolved? Is there anything else blocking this?

Fixes #16606. Closes #16373.

fix buggy show bounding box checkbox in connected-overlay-demo Fixes #16606. Closes #16373.

fix buggy show bounding box checkbox in connected-overlay-demo fix stylelint to work with WebStorm plugin Fixes #16606. Closes #16373.

devversion · 2019-10-17T20:45:00Z

@Splaktar One of the main issues is still that our getters/setters are too strict and break with --strictNullChecks I guess.

fix buggy show bounding box checkbox in connected-overlay-demo fix stylelint to work with WebStorm plugin Fixes #16606. Closes #16373.

- enable Ivy and fix template type checking in Bazel - for libraries, examples, dev-app, CI - add `postinstall` task for `ivy-ngcc` and configure it for our SystemJS setup - pin to Angular `9.0.0-next.10` for this PR - Angular `9.0.0-next.11` brings in a lot of new template type checking errors - fix buggy show bounding box checkbox in connected-overlay-demo - fix stylelint to work with WebStorm plugin - restrict NodeJS version to 10.x - We can't go to NodeJS 12.x without dropping or upgrading Gulp to 4.x - export `ProgressBarMode` type from `mdc-progress-bar` and `mat-progress-bar` - export `MatDrawerMode` type from `mat-drawer` - Add `| null` to `mat-tab-body`'s `@Input() origin: number;` Fixes #16606. Closes #16373.

angular-automatic-lock-bot · 2019-11-22T00:06:01Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

devversion requested review from andrewseguin, crisbeto, jelbourn, josephperrott and mmalerba as code owners June 24, 2019 20:08

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 24, 2019

devversion force-pushed the ivy-template-type-check branch from 0afcf02 to 149faa0 Compare June 24, 2019 20:09

devversion added the in progress This issue is currently in progress label Jun 24, 2019

devversion assigned jelbourn Jun 24, 2019

devversion force-pushed the ivy-template-type-check branch from 149faa0 to fe5761c Compare June 24, 2019 20:51

jelbourn reviewed Jun 24, 2019

View reviewed changes

devversion force-pushed the ivy-template-type-check branch from fe5761c to 0d7f1a8 Compare June 25, 2019 09:04

devversion added 6 commits June 26, 2019 19:47

build: make a11y-demo compatible with ivy template type checking

cb63d4f

build: make dev-app compatible with ivy template type checking

9b25d9c

build: components should be built with strict type checking

f15eac5

All components which are exported should be built with Ivy's strict template type checking. This guarantees maximum safety for template bindings and increases general code health in the components repository.

build: make material-examples compatible with ivy template type checking

8a9500f

build: build all bazel ng_module targets with strict template type ch…

b31b5af

…ecking

devversion force-pushed the ivy-template-type-check branch from 0d7f1a8 to b31b5af Compare June 26, 2019 17:48

devversion added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Jun 26, 2019

devversion mentioned this pull request Jul 1, 2019

fix(common): expand type for "ngForOf" input to work with strict null checks angular/angular#31371

Closed

JoostK mentioned this pull request Jul 13, 2019

feat(ivy): translate type-check diagnostics to their original source angular/angular#30181

Closed

3 tasks

Splaktar added the pr: needs rebase label Oct 4, 2019

Splaktar mentioned this pull request Oct 15, 2019

stepper: Type 'FormGroup' is not assignable to type 'FormControlLike' #16606

Closed

Splaktar added a commit that referenced this pull request Oct 15, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

3cba263

Fixes #16606. Closes #16373.

Splaktar mentioned this pull request Oct 15, 2019

refactor: enable Ivy and fix template type checking issues #17392

Merged

7 tasks

Splaktar added a commit that referenced this pull request Oct 16, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

2adff8a

Fixes #16606. Closes #16373.

Splaktar added a commit that referenced this pull request Oct 16, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

813991a

Fixes #16606. Closes #16373.

Splaktar added a commit that referenced this pull request Oct 17, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

d8f6d3d

Fixes #16606. Closes #16373.

Splaktar added a commit that referenced this pull request Oct 17, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

e92add8

Fixes #16606. Closes #16373.

Splaktar added a commit that referenced this pull request Oct 17, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

255d6ee

fix buggy show bounding box checkbox in connected-overlay-demo Fixes #16606. Closes #16373.

Splaktar added a commit that referenced this pull request Oct 17, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

32fe812

fix buggy show bounding box checkbox in connected-overlay-demo fix stylelint to work with WebStorm plugin Fixes #16606. Closes #16373.

Splaktar added a commit that referenced this pull request Oct 17, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

e580a12

fix buggy show bounding box checkbox in connected-overlay-demo fix stylelint to work with WebStorm plugin Fixes #16606. Closes #16373.

Splaktar added a commit that referenced this pull request Oct 18, 2019

refactor(dev-app): enable Ivy and fix template type checking issues

d539f13

fix buggy show bounding box checkbox in connected-overlay-demo fix stylelint to work with WebStorm plugin Fixes #16606. Closes #16373.

Splaktar added a commit that referenced this pull request Oct 18, 2019

refactor: enable Ivy and fix template type checking issues

a67fe70

fix buggy show bounding box checkbox in connected-overlay-demo fix stylelint to work with WebStorm plugin Fixes #16606. Closes #16373.

mmalerba closed this in #17392 Oct 22, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build: ensure components can be built with ivy strict template type checking #16373

build: ensure components can be built with ivy strict template type checking #16373

Uh oh!

devversion commented Jun 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jelbourn Jun 24, 2019

Uh oh!

Splaktar Oct 15, 2019

Uh oh!

jelbourn Jun 24, 2019

Uh oh!

devversion Jun 25, 2019

Uh oh!

jelbourn Jun 24, 2019

Uh oh!

devversion Jun 25, 2019 •

edited

Loading

Uh oh!

Uh oh!

Splaktar commented Oct 15, 2019

Uh oh!

devversion commented Oct 17, 2019

Uh oh!

angular-automatic-lock-bot bot commented Nov 22, 2019

Uh oh!

Uh oh!

build: ensure components can be built with ivy strict template type checking #16373

build: ensure components can be built with ivy strict template type checking #16373

Uh oh!

Conversation

devversion commented Jun 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jelbourn Jun 24, 2019

Choose a reason for hiding this comment

Uh oh!

Splaktar Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

jelbourn Jun 24, 2019

Choose a reason for hiding this comment

Uh oh!

devversion Jun 25, 2019

Choose a reason for hiding this comment

Uh oh!

jelbourn Jun 24, 2019

Choose a reason for hiding this comment

Uh oh!

devversion Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Splaktar commented Oct 15, 2019

Uh oh!

devversion commented Oct 17, 2019

Uh oh!

angular-automatic-lock-bot bot commented Nov 22, 2019

Uh oh!

Uh oh!

devversion Jun 25, 2019 •

edited

Loading