fix error when disabling eager_loading #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Dec 20, 2017
| @@ -412,8 +412,10 @@ private function registerDoctrineExtensionConfiguration(ContainerBuilder $contai | |||
| return; | |||
| } | |||
|
|
|||
| $container->removeDefinition('api_platform.doctrine.orm.query_extension.eager_loading'); | |||
| $container->removeDefinition('api_platform.doctrine.orm.query_extension.filter_eager_loading'); | |||
| $container->removeAlias('api_platform.doctrine.orm.query_extension.eager_loading'); | |||
There was a problem hiding this comment.
👍 this is because of #1557 !
You should remove the alias EagerLoadingExtension::class (please use this instead of the string) and remove the definition by it's id indeed.
Nice catch!
There was a problem hiding this comment.
You are right, I misread the error message, the problem is on the alias. I'm fixing it right now
jdeniau
force-pushed
the
jd-fix-autowiringEagerLoading
branch
from
9edb56f to
b232a73
Compare
|
I'm merging 2.1 there are a bunch of conflicts I'll let you know when ready. |
jdeniau
force-pushed
the
jd-fix-autowiringEagerLoading
branch
from
b232a73 to
b9c9fa6
Compare
Introduced by d3b690e
jdeniau
force-pushed
the
jd-fix-autowiringEagerLoading
branch
from
b9c9fa6 to
a502622
Compare
|
Though you were on master my bad! |
soyuka
approved these changes
Dec 20, 2017
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…gerLoading fix error when disabling eager_loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by d3b690e