Add python EC2 E2E tests. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
reviewed
Mar 6, 2024
validator/src/main/resources/expected-data-template/python/ec2/aws-sdk-call-log.mustache
Show resolved
Hide resolved
srprash
approved these changes
Mar 7, 2024
zzhlogin
added a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Add python EC2 E2E tests.
zzhlogin
added a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Add python EC2 E2E tests.
zzhlogin
added a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Add python EC2 E2E tests.
zzhlogin
added a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Add python EC2 E2E tests.
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
AwsAttributeKeys holds useful attribute keys needed by multiple other classes. This is a roughly-carbon-copy file of https://github.com/aws-observability/aws-otel-java-instrumentation/blob/main/awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsAttributeKeys.java Callout: open-telemetry/opentelemetry-java-instrumentation#8710 has been resolved, and a new issue needs to be opened. The larger problem is that the `AWS_*_NAME` attributes only exist in Java. We will either need to add these to Python or (more likely) move away from these attributes and towards ones accepted in the [AWS service specific attributes semantic conventions](https://opentelemetry.io/docs/specs/semconv/cloud-providers/aws-sdk/#aws-service-specific-attributes). I've cut a backlog item for this. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
zzhlogin
added a commit
that referenced
this pull request
Sep 13, 2024
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
zzhlogin
added a commit
that referenced
this pull request
Sep 17, 2024
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add python EC2 E2E tests by mainly matching the feature parity with Java EC2 E2E tests. The following resource are created:
App Signals Enablement E2E Testing - Python EC2 Use Caseworkflow to be called by canary tests and main_build.terraform/pythonfor setting up configurations to deploy sample app via terraform in EC2 instances.validator/src/main/resources/expected-data-template/pythonto configure the expected log/trace/metrics emitted by sample app for validation. There are two resource difference between python and Java:1). The
Operationin python are exclude of/, for example in PythonOperationisGET aws-sdk-call, in Java isGET /aws-sdk-call2). For traces, Java there has an extra layer of subsegments wrapped around another subsegment, python dosen't.
3). For
aws-sdk-call, the generated subsegment is missingsubsegments[0].http.request.urldata.validator/src/main/resources/validations/pythonandPredefinedExpectedTemplate.java, map the validator toexpected-data-templateFurthermore, Python EC2 E2E test is using
t2.smallto support required pkg version.The workflow is tested here to confirm its functionality:
https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8177354385
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.