-
Notifications
You must be signed in to change notification settings - Fork 20
Add Retry Mechanism for Gradlew, Terraform, and Eksctl #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bafe1b6
to
b7df778
Compare
960f1a6
to
8aa7eb5
Compare
00d7855
to
fc1c9a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just code clarity and the ADOT override thing to discuss offline
31f5d68
to
653d631
Compare
75593f4
to
845f9f0
Compare
majanjua-amzn
approved these changes
Mar 2, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…ry-mechanism Add Retry Mechanism for Gradlew, Terraform, and Eksctl
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…ry-mechanism Add Retry Mechanism for Gradlew, Terraform, and Eksctl
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…ry-mechanism Add Retry Mechanism for Gradlew, Terraform, and Eksctl
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…ry-mechanism Add Retry Mechanism for Gradlew, Terraform, and Eksctl
zzhlogin
added a commit
that referenced
this pull request
Sep 13, 2024
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
zzhlogin
added a commit
that referenced
this pull request
Sep 17, 2024
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
There are occasional failures in the canary due to internet transient issue while downloading some external libraries
Description of changes:
Adding a retry mechanism to Gradlew, Terraform and Eksctl. Also manually implement Terraform rather than using the setup terraform Github Action
Test Run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8104615686
Test Run after review: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8115879115
Test Run after changing eq sign: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8117425277
Test Run after refactoring: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8118227976
Test Run after editing curl feature flag: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8118610550
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.