Skip to content

Add Retry Mechanism for Gradlew, Terraform, and Eksctl #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 2, 2024

Conversation

harrryr
Copy link
Contributor

@harrryr harrryr commented Mar 1, 2024

Issue #, if available:
There are occasional failures in the canary due to internet transient issue while downloading some external libraries

Description of changes:
Adding a retry mechanism to Gradlew, Terraform and Eksctl. Also manually implement Terraform rather than using the setup terraform Github Action

Test Run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8104615686
Test Run after review: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8115879115
Test Run after changing eq sign: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8117425277
Test Run after refactoring: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8118227976
Test Run after editing curl feature flag: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8118610550

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@harrryr harrryr force-pushed the add-retry-mechanism branch from bafe1b6 to b7df778 Compare March 1, 2024 00:39
@harrryr harrryr force-pushed the add-retry-mechanism branch from 960f1a6 to 8aa7eb5 Compare March 1, 2024 19:36
@harrryr harrryr force-pushed the add-retry-mechanism branch from 00d7855 to fc1c9a3 Compare March 1, 2024 21:30
Copy link
Contributor

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just code clarity and the ADOT override thing to discuss offline

@harrryr harrryr force-pushed the add-retry-mechanism branch from 31f5d68 to 653d631 Compare March 1, 2024 23:32
@harrryr harrryr force-pushed the add-retry-mechanism branch from 75593f4 to 845f9f0 Compare March 2, 2024 00:03
@harrryr harrryr merged commit 7dee03a into main Mar 2, 2024
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…ry-mechanism

Add Retry Mechanism for Gradlew, Terraform, and Eksctl
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…ry-mechanism

Add Retry Mechanism for Gradlew, Terraform, and Eksctl
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…ry-mechanism

Add Retry Mechanism for Gradlew, Terraform, and Eksctl
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…ry-mechanism

Add Retry Mechanism for Gradlew, Terraform, and Eksctl
zzhlogin added a commit that referenced this pull request Sep 13, 2024
# This is the 1st commit message:

Test concurency.

# The commit message #2 will be skipped:

# Dummy commit

# The commit message #3 will be skipped:

# Dummy commit

# The commit message #4 will be skipped:

# Dummy commit

# The commit message #5 will be skipped:

# Dummy commit

# The commit message #6 will be skipped:

# add push.

# The commit message #7 will be skipped:

# Dummy commit

# The commit message #8 will be skipped:

# Dummy commit

# The commit message #9 will be skipped:

# Dummy commit

# The commit message #10 will be skipped:

# Add push condition.

# The commit message #11 will be skipped:

# Dummy commit
zzhlogin added a commit that referenced this pull request Sep 17, 2024
# This is the 1st commit message:

Test concurency.

# The commit message #2 will be skipped:

# Dummy commit

# The commit message #3 will be skipped:

# Dummy commit

# The commit message #4 will be skipped:

# Dummy commit

# The commit message #5 will be skipped:

# Dummy commit

# The commit message #6 will be skipped:

# add push.

# The commit message #7 will be skipped:

# Dummy commit

# The commit message #8 will be skipped:

# Dummy commit

# The commit message #9 will be skipped:

# Dummy commit

# The commit message #10 will be skipped:

# Add push condition.

# The commit message #11 will be skipped:

# Dummy commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants