-
Notifications
You must be signed in to change notification settings - Fork 20
Add Retry for Remote Application, Addon, and EC2 Instance Inline #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b6e097
to
86df538
Compare
Check if ec2 instance inline code fail
86df538
to
9005f19
Compare
majanjua-amzn
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions but looks good.
e66f7a0
to
759c205
Compare
majanjua-amzn
approved these changes
Mar 6, 2024
majanjua-amzn
approved these changes
Mar 6, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…emote-application-and-addon Add Retry for Remote Application, Addon, and EC2 Instance Inline
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…emote-application-and-addon Add Retry for Remote Application, Addon, and EC2 Instance Inline
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…emote-application-and-addon Add Retry for Remote Application, Addon, and EC2 Instance Inline
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…emote-application-and-addon Add Retry for Remote Application, Addon, and EC2 Instance Inline
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
The Black linter was configured with an "exclude" file that was not correctly made - it was excluding anything with "dist" in the path, which included eachdist.py and the opentelemetry-distro directory. By default[1], Black uses the .gitignore file, which is a superset of what was specified in the exclude file, so just use that. Also ran and applied the linter. [1] https://black.readthedocs.io/en/stable/usage_and_configuration/file_collection_and_discovery.html By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
zzhlogin
added a commit
that referenced
this pull request
Sep 13, 2024
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
zzhlogin
added a commit
that referenced
this pull request
Sep 17, 2024
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8149233058
Test run after changing the execute_and_retry.sh into an action: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8165892010
Test run after increasing retry count: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8179788668
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.