Skip to content

Add Retry for Remote Application, Addon, and EC2 Instance Inline #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2024

Conversation

harrryr
Copy link
Contributor

@harrryr harrryr commented Mar 5, 2024

Issue #, if available:

  • EC2 Instance inline code occasionally fails due to segmentation fault, but Terraform does not detect the failure
  • Occasional failure during AppSignals Add-on Installation due to transient issues
  • Remote Sample Application is sometimes not deployed properly in EC2

Description of changes:

  • Add a line in the ec2 inline terraform code to cause terraform to fail if any command throws an error
  • Seperated app-signals addon step from the terraform deploy step and wrapped a retry mechanism around it
  • Also check if the remote sample application is deployed properly

Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8149233058
Test run after changing the execute_and_retry.sh into an action: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8165892010

Test run after increasing retry count: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8179788668

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@harrryr harrryr force-pushed the retry-remote-application-and-addon branch 2 times, most recently from 4b6e097 to 86df538 Compare March 6, 2024 04:14
Check if ec2 instance inline code fail
@harrryr harrryr force-pushed the retry-remote-application-and-addon branch from 86df538 to 9005f19 Compare March 6, 2024 04:49
Copy link
Contributor

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions but looks good.

@harrryr harrryr force-pushed the retry-remote-application-and-addon branch from e66f7a0 to 759c205 Compare March 6, 2024 22:52
@harrryr harrryr requested a review from majanjua-amzn March 6, 2024 22:53
@majanjua-amzn majanjua-amzn self-requested a review March 6, 2024 22:58
@harrryr harrryr merged commit 50325c4 into main Mar 6, 2024
@harrryr harrryr deleted the retry-remote-application-and-addon branch March 6, 2024 22:59
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…emote-application-and-addon

Add Retry for Remote Application, Addon, and EC2 Instance Inline
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…emote-application-and-addon

Add Retry for Remote Application, Addon, and EC2 Instance Inline
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…emote-application-and-addon

Add Retry for Remote Application, Addon, and EC2 Instance Inline
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…emote-application-and-addon

Add Retry for Remote Application, Addon, and EC2 Instance Inline
georgeboc pushed a commit to georgeboc/aws-application-signals-test-framework that referenced this pull request Jul 8, 2024
The Black linter was configured with an "exclude" file that was not
correctly made - it was excluding anything with "dist" in the path,
which included eachdist.py and the opentelemetry-distro directory. By
default[1], Black uses the .gitignore file, which is a superset of what
was specified in the exclude file, so just use that. Also ran and
applied the linter.

[1]
https://black.readthedocs.io/en/stable/usage_and_configuration/file_collection_and_discovery.html

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
zzhlogin added a commit that referenced this pull request Sep 13, 2024
# This is the 1st commit message:

Test concurency.

# The commit message #2 will be skipped:

# Dummy commit

# The commit message #3 will be skipped:

# Dummy commit

# The commit message #4 will be skipped:

# Dummy commit

# The commit message #5 will be skipped:

# Dummy commit

# The commit message #6 will be skipped:

# add push.

# The commit message #7 will be skipped:

# Dummy commit

# The commit message #8 will be skipped:

# Dummy commit

# The commit message #9 will be skipped:

# Dummy commit

# The commit message #10 will be skipped:

# Add push condition.

# The commit message #11 will be skipped:

# Dummy commit
zzhlogin added a commit that referenced this pull request Sep 17, 2024
# This is the 1st commit message:

Test concurency.

# The commit message #2 will be skipped:

# Dummy commit

# The commit message #3 will be skipped:

# Dummy commit

# The commit message #4 will be skipped:

# Dummy commit

# The commit message #5 will be skipped:

# Dummy commit

# The commit message #6 will be skipped:

# add push.

# The commit message #7 will be skipped:

# Dummy commit

# The commit message #8 will be skipped:

# Dummy commit

# The commit message #9 will be skipped:

# Dummy commit

# The commit message #10 will be skipped:

# Add push condition.

# The commit message #11 will be skipped:

# Dummy commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants