-
Notifications
You must be signed in to change notification settings - Fork 490
Prepare for Test Tool v2 Release #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: use System.CommandLine to create a CLI application
feat: minor test tool v2 UI update
feat: add code editor to properly display json
…ening function and support for RequestResponse invocation type. (#1912)
feat: add multiple function support
Merge dev into lambda test tool branch
ci: run test tool v2 tests in PR checks
…is hosted by Aspire (#1951)
Tools/LambdaTestTool-v2/src/Amazon.Lambda.TestTool/Processes/TestToolProcess.cs
Fixed
Show fixed
Hide fixed
{ | ||
name = name.Substring(name.IndexOf("@") + 1); | ||
var path = Path.Combine(GetSavedRequestDirectory(), name); | ||
return File.ReadAllText(path); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: csharp.lang.security.filesystem.unsafe-path-combine.unsafe-path-combine Warning
String argument name is used to read or write data from a file via Path.Combine without direct sanitization via Path.GetFileName. If the path is user-supplied data this can lead to path traversal.
normj
approved these changes
Jan 30, 2025
ghost
approved these changes
Jan 30, 2025
chore: fix semgrep complaints
Tools/LambdaTestTool-v2/src/Amazon.Lambda.TestTool/Processes/TestToolProcess.cs
Dismissed
Show dismissed
Hide dismissed
chore: ignore semgrep finding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Prepare for Test Tool v2 Release
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.