Skip to content

feat: support bi-directional eventstream over H2 #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 27, 2020

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Apr 6, 2020

This PR is depend on #1081

  1. Add AddHttp2Dependency.java to add Http/2 request handler to service: TranscribeStreaming and Kinesis. Currently only NodeJs requires special request handler for Http/2.
  2. Add AddEventStreamHandlingDependency.java to support signing event stream in requests with SigV4 streaming spec
  3. Add eventstream-handler-node and middleware-eventstream for JS implementation of singing eventstream requests

This PR is ready to be reviewed but needs to be merged together with WebSocket support.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 84cb0d4 to fdb88f8 Compare April 6, 2020 16:20
@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #1082 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   73.33%   73.36%   +0.02%     
==========================================
  Files         285      286       +1     
  Lines       12399    12412      +13     
  Branches     2892     2899       +7     
==========================================
+ Hits         9093     9106      +13     
  Misses       3306     3306              
Impacted Files Coverage Δ
...eventstream-handler-node/src/EventSigningStream.ts 91.66% <ø> (ø)
...ream-handler-node/src/EventStreamPayloadHandler.ts 96.00% <ø> (ø)
...sal/src/fixtures/MockEventMessageSource.fixture.ts 86.36% <ø> (ø)
...ream-serde-universal/src/fixtures/event.fixture.ts 100.00% <ø> (ø)
...ventstream-serde-universal/src/getChunkedStream.ts 94.23% <ø> (ø)
...tream-serde-universal/src/getUnmarshalledStream.ts 73.07% <ø> (ø)
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 63.56% <ø> (-0.04%) ⬇️
protocol_tests/aws-json/protocols/Aws_json1_1.ts 66.04% <ø> (-0.62%) ⬇️
protocol_tests/aws-query/protocols/Aws_query.ts 68.60% <ø> (-0.11%) ⬇️
...ol_tests/aws-restjson/protocols/Aws_restJson1_1.ts 62.04% <ø> (-0.11%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117e9ca...8e9bbc0. Read the comment docs.

@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP requested a review from kstich April 8, 2020 18:49
@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 3e17e70 to 02f600d Compare April 12, 2020 22:31
@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 02f600d to 7de6a68 Compare May 4, 2020 18:32
@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP
Copy link
Contributor Author

This PR needs to be revised because of the new design.

@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 3f5bc86 to 084d405 Compare May 8, 2020 06:55
@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 084d405 to e271da9 Compare May 9, 2020 01:32
@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from e271da9 to 94e79c4 Compare May 11, 2020 16:05
@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 94e79c4 to 5ddc871 Compare May 11, 2020 16:20
@AllanZhengYP AllanZhengYP marked this pull request as ready for review May 11, 2020 16:22
@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 5ddc871 to 7f86b04 Compare May 11, 2020 17:57
@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from d0613df to eaddfd0 Compare May 12, 2020 06:22
@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 8e9bbc0 to 080efeb Compare May 25, 2020 00:27
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

❗ No coverage uploaded for pull request head (h2-eventstream-continue@5e49dcc). Click here to learn what that means.
The diff coverage is n/a.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 080efeb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP requested a review from kstich May 27, 2020 07:36
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 6620c4c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP force-pushed the h2-eventstream-continue branch from 6620c4c to 5e49dcc Compare May 27, 2020 18:18
@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 5e49dcc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear from Java side

@AllanZhengYP AllanZhengYP merged commit af41a53 into aws:master May 27, 2020
@trivikr trivikr mentioned this pull request May 28, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants