Skip to content

fix: use unique training job names in TensorFlow script mode integ tests #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

icywang86rui
Copy link
Contributor

@icywang86rui icywang86rui commented Apr 9, 2019

Issue #, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@icywang86rui
Copy link
Contributor Author

I have run the tests locally the job names look good:

INFO:sagemaker:Creating training-job with name: test-tf-sm-mnist-1554829563-cc7d
INFO:sagemaker:Creating training-job with name: test-tf-sm-mnist-1554829562-9162
INFO:sagemaker:Creating training-job with name: test-tf-sm-distributed-1554829562-4f2f
INFO:sagemaker:Creating training-job with name: test-tf-sm-distributed-1554829563-c1ac

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu laurenyu merged commit 7146911 into aws:master Apr 9, 2019
nmadan added a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
nmadan added a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
nmadan added a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants