Skip to content

refactor: [SQLSRV] convert ENUM to VARCHAR(n) in Forge #8478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2024
Merged

refactor: [SQLSRV] convert ENUM to VARCHAR(n) in Forge #8478

merged 3 commits into from
Feb 4, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 29, 2024 •
edited
Loading

Description
Closes #8443

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added database Issues or pull requests that affect the database layer 4.5 labels Jan 29, 2024
@kenjis kenjis marked this pull request as draft January 30, 2024 05:30
@kenjis kenjis force-pushed the fix-sqlsrv-forge-enum branch from 132c167 to 41fca22 Compare January 31, 2024 01:30
@kenjis kenjis marked this pull request as ready for review January 31, 2024 01:47
@kenjis kenjis force-pushed the fix-sqlsrv-forge-enum branch from 362a11d to 88362f9 Compare January 31, 2024 01:48
@kenjis kenjis merged commit d22812d into codeigniter4:4.5 Feb 4, 2024
@kenjis kenjis deleted the fix-sqlsrv-forge-enum branch February 4, 2024 23:58
This was referenced Feb 4, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn