Skip to content

[automated] Merge branch 'release/3.0' => 'release/3.1' #14602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro-bot
Copy link
Contributor

I detected changes in the release/3.0 branch which have not been merged yet to release/3.1. I'm a robot and am configured to help you automatically keep release/3.1 up to date, so I've opened this PR.

This PR merges commits made on release/3.0 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/3.0
git pull --ff-only
git checkout release/3.1
git pull --ff-only
git merge --no-ff release/3.0

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/3.0-to-release/3.1
or if you are using SSH
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/3.0-to-release/3.1

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/3.0-to-release/3.1'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/3.0-to-release/3.1 release/3.1
git pull https://github.com/dotnet-maestro-bot/AspNetCore merge/release/3.0-to-release/3.1
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/3.0-to-release/3.1
or if you are using SSH
git checkout -b merge/release/3.0-to-release/3.1 release/3.1
git pull [email protected]:dotnet-maestro-bot/AspNetCore merge/release/3.0-to-release/3.1
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/3.0-to-release/3.1

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

dougbu and others added 21 commits September 23, 2019 22:45
- aspnet/AspNetCore-Internal#3153
…/2.1-to-release/2.2

[automated] Merge branch 'release/2.1' => 'release/2.2'
- aspnet/AspNetCore-Internal#3153
- add `$(IgnorePackageBaselines)` property
- no changes in known frameworks, targeting pack features, et cetera
- `$(IsServicingBuild)` disabled at the moment
- work around dotnet/core-eng#7970
- install Git in repo if Tar can't be found in usual locations
- use found or installed Tar in Microsoft.AspNetCore.App.Ref project
  - copy into repo from wherever it's found
- add lots of `Write-Host` debugging

nit: clean up / comment on VS Code warnings about build.ps1
- includes workarounds that should be removed or improved ASAP
  e.g. dotnet@f219a38 and dotnet@fd34e14
@dotnet-maestro-bot dotnet-maestro-bot requested review from dougbu and a team as code owners October 1, 2019 04:10
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 1, 2019
@dotnet-maestro-bot
Copy link
Contributor Author

❌ Uh oh, this pull request could not be updated automatically. New commits were pushed to release/3.0, but I could not automatically push those to merge/release/3.0-to-release/3.1 to update this PR.
You may need to fix this problem by merging branches with this PR. Contact .NET Core Engineering if you are not sure what to do about this.

@dougbu
Copy link
Contributor

dougbu commented Oct 1, 2019

@wtgodbe or @JunTaoLuo could one of you please do a manual merge? It's not clear that what's being tested is up-to-date with what's in 'release/3.1'. Lots of "missing part of the path" issues that imply the targeting pack (Microsoft.AspNetCore.App.Ref in particular) didn't build.

@JunTaoLuo JunTaoLuo self-assigned this Oct 1, 2019
@dotnet-maestro-bot
Copy link
Contributor Author

❌ Uh oh, this pull request could not be updated automatically. New commits were pushed to release/3.0, but I could not automatically push those to merge/release/3.0-to-release/3.1 to update this PR.
You may need to fix this problem by merging branches with this PR. Contact .NET Core Engineering if you are not sure what to do about this.

@dotnet-maestro-bot
Copy link
Contributor Author

❌ Uh oh, this pull request could not be updated automatically. New commits were pushed to release/3.0, but I could not automatically push those to merge/release/3.0-to-release/3.1 to update this PR.
You may need to fix this problem by merging branches with this PR. Contact .NET Core Engineering if you are not sure what to do about this.

@dougbu
Copy link
Contributor

dougbu commented Oct 10, 2019

Recreate the merge commit for validation (again)

@dougbu dougbu closed this Oct 10, 2019
@dougbu dougbu reopened this Oct 10, 2019
@wtgodbe
Copy link
Member

wtgodbe commented Oct 14, 2019

Looks like this would be fixed by #14746 - should I get that one in now (CI is green)?

@dotnet-maestro-bot
Copy link
Contributor Author

❌ Uh oh, this pull request could not be updated automatically. New commits were pushed to release/3.0, but I could not automatically push those to merge/release/3.0-to-release/3.1 to update this PR.
You may need to fix this problem by merging branches with this PR. Contact .NET Core Engineering if you are not sure what to do about this.

@dougbu
Copy link
Contributor

dougbu commented Oct 14, 2019

Looks like this would be fixed by #14746 - should I get that one in now (CI is green)?

& hellip;

New commits were pushed to release/3.0, but I could not automatically push those to merge/release/3.0-to-release/3.1 to update this PR.

@wtgodbe please follow the "Instructions for merging via command line" to bring this PR up-to-date w.r.t. both 'release/3.0' and 'release/3.1'. Differences from the current branch should be fairly easy to review but do make sure manual fixups like ab8185b and 8534db0 are redone in your merge.

@wtgodbe wtgodbe assigned wtgodbe and unassigned JunTaoLuo Oct 14, 2019
@dotnet-maestro-bot
Copy link
Contributor Author

❌ Uh oh, this pull request could not be updated automatically. New commits were pushed to release/3.0, but I could not automatically push those to merge/release/3.0-to-release/3.1 to update this PR.
You may need to fix this problem by merging branches with this PR. Contact .NET Core Engineering if you are not sure what to do about this.

@wtgodbe wtgodbe merged commit 2c6d7a0 into dotnet:release/3.1 Oct 16, 2019
@dougbu dougbu removed the blocked The work on this issue is blocked due to some dependency label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.