Skip to content

history: error boundary #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2025
Merged

history: error boundary #1544

merged 5 commits into from
Mar 6, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 5, 2025

Asana Task/Github Issue: https://app.asana.com/0/492600419927320/1209580861623842

Description

  • global error handler that allows a page reload

Testing Steps

  • Run locally with npm run watch -- --page history -v (run inside special-pages)
  • Place a throw new Error('oops!') in any component, such as special-pages/pages/history/app/components/App.jsx
  • verify you see the recovery UI
  • NOTE: this is more of a debugging tool, it's not expected to be shown to users. If it were, there'd be a much bigger issue.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Mar 5, 2025

Copy link

github-actions bot commented Mar 5, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 5, 2025

[Beta] Generated file diff

Time updated: Thu, 06 Mar 2025 06:41:13 GMT

Integration
    - integration/pages/history/dist/index.css
  • integration/pages/history/dist/index.js
  • integration/pages/history/locales/en/history.json

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/history/dist/index.js
  • windows/pages/history/locales/en/history.json

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/history/dist/index.js
  • dist/pages/history/locales/en/history.json

File has changed

@shakyShane shakyShane marked this pull request as ready for review March 5, 2025 13:08
@shakyShane shakyShane requested review from mgurgel and a team as code owners March 5, 2025 13:08
Base automatically changed from 03-05-history_add_source_for_each_query to main March 5, 2025 14:15
@shakyShane shakyShane force-pushed the 03-05-history_error_boundary branch from cfe0841 to 2ef98e5 Compare March 5, 2025 14:16
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit ef32030
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67c94351905a340008fb359c
😎 Deploy Preview https://deploy-preview-1544--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vkraucunas
vkraucunas previously approved these changes Mar 5, 2025
Copy link
Contributor

@vkraucunas vkraucunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve tested this locally, and added the error in multiple components on the page, even inside an onclick for fun. The errors put in the components worked as intended, the onclick didn’t do anything but that’s to be expected 😄

@shakyShane shakyShane merged commit 70a1c30 into main Mar 6, 2025
14 checks passed
@shakyShane shakyShane deleted the 03-05-history_error_boundary branch March 6, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants