Skip to content

history: reset when clicking outside the main container #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 5, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209532669589622/f

Description

  • Before, only the main container would capture additional clicks (to deselect)
  • After: now any click outside of buttons and links will cause the selections to reset

Testing Steps

  • npm run watch -- --page history -v
  • select a row, then click something like the header, or below the sidebar links, everything should de-select

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Mar 5, 2025

@shakyShane shakyShane mentioned this pull request Mar 5, 2025
9 tasks
Copy link

github-actions bot commented Mar 5, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 5, 2025

[Beta] Generated file diff

Time updated: Thu, 06 Mar 2025 06:54:11 GMT

Integration
    - integration/pages/history/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.js

File has changed

Apple
    - dist/pages/history/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review March 5, 2025 20:33
@shakyShane shakyShane requested review from mgurgel and a team as code owners March 5, 2025 20:33
@shakyShane shakyShane force-pushed the 03-05-history_reset_when_clicking_outside_the_main_container branch from e7091d6 to 25a0492 Compare March 5, 2025 20:35
}
} else {
dispatch({ kind: 'reset', reason: 'click occurred outside of rows' });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is where it reset previously, but this handler was only scoped to the main tag.

vkraucunas
vkraucunas previously approved these changes Mar 5, 2025
Copy link
Contributor

@vkraucunas vkraucunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This performs as expected too! No random numerals to flag in this PR.

@shakyShane shakyShane force-pushed the 03-05-history_reset_when_clicking_outside_the_main_container branch from 25a0492 to 900f21c Compare March 6, 2025 06:40
Base automatically changed from 03-05-history_error_boundary to main March 6, 2025 06:48
@shakyShane shakyShane dismissed vkraucunas’s stale review March 6, 2025 06:48

The base branch was changed.

@shakyShane shakyShane force-pushed the 03-05-history_reset_when_clicking_outside_the_main_container branch from 900f21c to 764c3ba Compare March 6, 2025 06:53
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 764c3ba
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67c94659285ad400086f4d3f
😎 Deploy Preview https://deploy-preview-1546--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane merged commit 0dd42f6 into main Mar 6, 2025
12 checks passed
@shakyShane shakyShane deleted the 03-05-history_reset_when_clicking_outside_the_main_container branch March 6, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants