-
Notifications
You must be signed in to change notification settings - Fork 28
history: reset when clicking outside the main container #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
history: reset when clicking outside the main container #1546
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 06 Mar 2025 06:54:11 GMT Integration
File has changed Windows
File has changed Apple
File has changed |
e7091d6
to
25a0492
Compare
} | ||
} else { | ||
dispatch({ kind: 'reset', reason: 'click occurred outside of rows' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is where it reset previously, but this handler was only scoped to the main
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This performs as expected too! No random numerals to flag in this PR.
25a0492
to
900f21c
Compare
900f21c
to
764c3ba
Compare
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Asana Task/Github Issue: https://app.asana.com/0/0/1209532669589622/f
Description
Testing Steps
npm run watch -- --page history -v
Checklist
Please tick all that apply: