Start of fixes for core/search

[sethmlarson]

Part of #1878

[swallez]

Looks good so far!

[swallez]

Does null for this field exist in the recordings? I can't relate this to one of the Java client errors (which actually doesn't error out on null for optional fields).

[sethmlarson]

Yeah this was in one of the recordings not a fix for Java specifically.

[sethmlarson]

I went looking for the test this is from and couldn't find it so reverted this change for now.

[github-actions]

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
field_caps	🔴	50/51	51/51
search	🔴	1552/1583	1562/1565

You can validate these APIs yourself by using the make validate target.

[swallez]

LGTM

[github-actions]

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1947-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 dacbd3cf71ea2b3331169befe0e82d72c5a06e52
# Push it to GitHub
git push --set-upstream origin backport-1947-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1947-to-7.17.